Skip to content

Comments

chromedriver: fix build failure on aarch64-darwin#329204

Merged
K900 merged 1 commit intoNixOS:masterfrom
n8henrie:issue_329202
Jul 30, 2024
Merged

chromedriver: fix build failure on aarch64-darwin#329204
K900 merged 1 commit intoNixOS:masterfrom
n8henrie:issue_329202

Conversation

@n8henrie
Copy link
Contributor

@n8henrie n8henrie commented Jul 22, 2024

Darwin seems to need unzip and chokes on autoPatchelfHook.

Fixes #329202

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 22, 2024
@n8henrie
Copy link
Contributor Author

n8henrie commented Jul 23, 2024

cc @goibhniu @primeos @K900 @paveloom

@K900
Copy link
Contributor

K900 commented Jul 23, 2024

Is unzip only necessary on Darwin then?

@n8henrie
Copy link
Contributor Author

n8henrie commented Jul 23, 2024

Hmm, apparently -- I'll make it conditional.

@K900
Copy link
Contributor

K900 commented Jul 23, 2024

Wait, I'm confused. How do we have unzip on Linux, but not Darwin? Does our default unpacking logic handle different file types depending on platform? What the fuck

@n8henrie
Copy link
Contributor Author

n8henrie commented Jul 23, 2024

I was wondering the same.

@K900
Copy link
Contributor

K900 commented Jul 23, 2024

Wait, I'm an idiot. We're doing a source build on Linux now, so this expression isn't even hit. We can probably drop all the conditionals and make it Darwin only then, because it's not like there are binaries for other systems anyway.

@n8henrie
Copy link
Contributor Author

n8henrie commented Jul 24, 2024

Yes, I thought maybe it had been exposed as a separate -bin package, but it looks like it just switches on availability of pkgs.chromium for platform.

I'd be happy to pull out the linux stuff from binary.nix if you think it should be removed.

@K900
Copy link
Contributor

K900 commented Jul 24, 2024

I think that's the way to go, yeah.

@n8henrie
Copy link
Contributor Author

n8henrie commented Jul 24, 2024

Done. As this modified quite a bit of the file I also formatted (RFC style).

@n8henrie
chromedriver: fix build failure on aarch64-darwin
dc96961 
Darwin seems to need `unzip` and chokes on `autoPatchelfHook`. Because
linux now builds from source, the package has been updated to remove
references to Linux-specific settings and build options, remove the
conditionals checking for darwin, and adjust the platforms to reflect
that the binary chromedriver is darwin-only.

Fixes NixOS#329202
@kirillrdy kirillrdy requested review from K900 and jonochang July 30, 2024 04:43
jonochang
jonochang approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@jonochang jonochang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 329204 run on aarch64-darwin 1

2 packages built:
  • selendroid
  • selenium-server-standalone

@K900 K900 merged commit 3ad9d21 into NixOS:master Jul 30, 2024
@emilylange emilylange mentioned this pull request Nov 21, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@K900 K900 Awaiting requested review from K900

1 more reviewer

@jonochang jonochang jonochang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: chromedriver (aarch64-darwin)

3 participants

@n8henrie @K900 @jonochang