ffmpeg: Patch for compatibility with 10.12 AVFoundation#328424
ffmpeg: Patch for compatibility with 10.12 AVFoundation#328424Atemu merged 1 commit intoNixOS:masterfrom
Conversation
|
Do you have any plans to try upstreaming this to FFmpeg or would you prefer someone else brave the rapids? |
ofborg
bot
added
10.rebuild-darwin: 1-10
|
Result of 1 package marked as broken and skipped:
7 packages failed to build:
15 packages built:
|
|
@emilazy, I think we should respect upstream's decision to support a minimum of 10.13, TBH. That's already quite generous. This is just a temporary band-aid for us. |
|
Maybe we should follow suit :') |
|
For clarity the failures on ffmpeg_7-full are expected. That requires more fixes. |
| -static NSArray* getDevicesWithMediaType(AVMediaType mediaType) { | ||
| +static NSArray* getDevicesWithMediaType(NSString * mediaType) { |
There was a problem hiding this comment.
For how long will this be forward compatible?
There was a problem hiding this comment.
It looks like AVMediaType was introduced in 10.13, and is documented as an alias, so probably for a while unless there’s explicit notice that depending on it being an alias is deprecated?
This was disabled in NixOS#322724 after NixOS#328424 provided a patch fixing it.
4 participants
Description of changes
This patch conflicts mildly with #322724, if that is merged first this one should be updated not to disable AVFoundation, if this is merged first that PR should be updated not to introduce the disabling.
The vendored patch can be dropped as soon as we start building ffmpeg against a newer SDK but the effort to make it compatible with 10.12 was very minor.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.