python3Packages.thrift: Fix python 3.12 support#328246
Closed
kfollesdal wants to merge 2 commits intoNixOS:masterfrom
Closed
python3Packages.thrift: Fix python 3.12 support#328246kfollesdal wants to merge 2 commits intoNixOS:masterfrom
kfollesdal wants to merge 2 commits intoNixOS:masterfrom
Conversation
Closed
13 tasks
Member
|
Just leaving a comment to keep me in the loop, as this PR and #326321 are essentially targeting the same issue. |
13 tasks
Member
|
What about using a distutils package from PyPI on Python 3.12? #328379 |
Contributor
Author
|
We can also consider to fix setuptools to behave as expected by adding the following lines to setuptools: But will give mass rebuild, but solve build problems for other python packages and avoid problems/confusion. Will make a PR, that can be evaluated. |
Closed
13 tasks
Contributor
Author
|
See #328415 for proposal to fix |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This give python package
thriftpython 3.12 support.Is a better and simpler solutions than first attempt that modify
setuptools: #328182Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.