Skip to content

python3Packages.thrift: Fix python 3.12 support#328246

Closed
kfollesdal wants to merge 2 commits intoNixOS:masterfrom
kfollesdal:kfollesdal/thrift-fix
Closed

python3Packages.thrift: Fix python 3.12 support#328246
kfollesdal wants to merge 2 commits intoNixOS:masterfrom
kfollesdal:kfollesdal/thrift-fix

Conversation

@kfollesdal
Copy link
Contributor

Description of changes

This give python package thrift python 3.12 support.

Is a better and simpler solutions than first attempt that modify setuptools: #328182

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 18, 2024
@kfollesdal kfollesdal requested a review from fabaff July 18, 2024 18:58
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jul 18, 2024
@ofborg ofborg bot requested a review from hbunke July 18, 2024 19:52
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 18, 2024
@wegank
Copy link
Member

wegank commented Jul 18, 2024

Just leaving a comment to keep me in the loop, as this PR and #326321 are essentially targeting the same issue.

@dotlambda
Copy link
Member

dotlambda commented Jul 19, 2024

What about using a distutils package from PyPI on Python 3.12? #328379

@kfollesdal
Copy link
Contributor Author

We can also consider to fix setuptools to behave as expected by adding the following lines to setuptools:

postInstall = ''
  ln -s $out/${python.sitePackages}/setuptools/_distutils  $out/${python.sitePackages}/distutils
 '';

But will give mass rebuild, but solve build problems for other python packages and avoid problems/confusion.

Will make a PR, that can be evaluated.

@kfollesdal
Copy link
Contributor Author

See #328415 for proposal to fix setuptools to behave as expected.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@ghost ghost closed this Dec 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants