nodePackages.node2nix: use top-level cctools in generated files#328167
Merged
emilazy merged 1 commit intoNixOS:masterfrom Jul 26, 2024
Merged
nodePackages.node2nix: use top-level cctools in generated files#328167emilazy merged 1 commit intoNixOS:masterfrom
emilazy merged 1 commit intoNixOS:masterfrom
Conversation
13 tasks
github-actions
bot
added
the
6.topic: nodejs
dotlambda
reviewed
Jul 18, 2024
ofborg
bot
added
10.rebuild-darwin: 1-10
reckenrode
force-pushed
the
node2nix-cctools
branch
from
3b4e51e to
9793073
Compare
emilazy
approved these changes
Jul 26, 2024
Member
emilazy
left a comment
emilazy
left a comment
There was a problem hiding this comment.
Successfully regenerated and built base16-builder. It’s web scale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Update node2nix in nixpkgs to use top-level cctools when it’s available, which should avoid evaluation errors after in-tree users update their files when aliases are disabled.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.