Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] nixos/tsm-client: Fix multi-value dsm.sys options #328031

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-24.05, triggered by a label in #327748.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

A configuration such as:

    programs.tsmClient.servers.backup.domain = [ "/dir1" "dir2" ];

...would previously result in an error ("cannot coerce a list to a
string"), since `makeDsmSysLines` would return a nested list.

(cherry picked from commit f52ee2a)
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jul 17, 2024
@Yarny0
Copy link
Contributor

Yarny0 commented Jul 18, 2024

Review per https://github.com/NixOS/nixpkgs/blob/d95b1060ca298c62f56de90d0bf755c4c6b48e0a/nixos/README.md#module-updates

Reviewed points
  • changes are backward compatible
  • removed options are declared with mkRemovedOptionModule
  • changes that are not backward compatible are documented in release notes
  • module tests succeed on x86-64
  • options types are appropriate
  • options description is set
  • options example is provided
  • documentation affected by the changes is updated
Possible improvements

(none)

Comments

Tested again, this time with NixOS 24.05 (stable). I can confirm: After applying the pull request at hand, values with a list, true and null all yield what is expected.

I approve this pull request and recommend it to be merged.

(Note: I'm the maintainer of the tsm-client module)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1836

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1866

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1907

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1926

@SuperSandro2000 SuperSandro2000 merged commit baca756 into release-24.05 Sep 1, 2024
16 checks passed
@SuperSandro2000 SuperSandro2000 deleted the backport-327748-to-release-24.05 branch September 1, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants