Skip to content

maturin: 1.6.0 -> 1.7.0#327429

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
getchoo-contrib:pkgs/maturin/1.7.0
Jul 17, 2024
Merged

maturin: 1.6.0 -> 1.7.0#327429
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
getchoo-contrib:pkgs/maturin/1.7.0

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Jul 15, 2024

Description of changes

Changelog: https://github.com/PyO3/maturin/releases/tag/v1.7.0
Diff: PyO3/maturin@v1.6.0...v1.7.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test build a package that uses this to make sure things are not regressing majorly?

@getchoo
Copy link
Member Author

getchoo commented Jul 15, 2024

Rebuilt uv on nixos-unstable with the following

let
  overlay = final: _: { maturin = final.callPackage ./pkgs/by-name/ma/maturin/package.nix { }; };
  pkgs = import <nixpkgs> {
    system = builtins.currentSystem;
    config = { };
    overlays = [ overlay ];
  };
in
  pkgs.uv

passthru.tests.pyo3 also builds

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jul 15, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 16, 2024
@SuperSandro2000 SuperSandro2000 merged commit 969287e into NixOS:staging Jul 17, 2024
@getchoo getchoo deleted the pkgs/maturin/1.7.0 branch July 17, 2024 19:19
@getchoo getchoo mentioned this pull request Aug 23, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants