haskellPackages.with-utf8: fix build on x86 darwin.#327322
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Jul 25, 2024
Merged
haskellPackages.with-utf8: fix build on x86 darwin.#327322maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
github-actions
bot
added
the
6.topic: haskell
Member
|
Thx! |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Messed up my rebase onto
haskell-updatesin #327204 and triggered a mass notification 😳. Resubmitting here with the correct diff.This should fix a build error (missing libchatset.h) for with-utf8 that manifests on x86 darwin only (hydra. The first build that started failing here was #259447667, which contains some changes to the libiconv package (#301354) that may be the root cause of the regression.
The pr here simply conditionaly adds libiconv to extraLibraries for with-utf8 on x86 darwin only, and doesn't dig deeper into the stdenv changes (which are unfortunately a little out of my league).
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.