Skip to content

lerc: expose available pkg-config modules via meta#327213

Merged
dotlambda merged 2 commits intoNixOS:masterfrom
sternenseemann:lerc-pkg-config
Jul 18, 2024
Merged

lerc: expose available pkg-config modules via meta#327213
dotlambda merged 2 commits intoNixOS:masterfrom
sternenseemann:lerc-pkg-config

Conversation

@sternenseemann
Copy link
Member

Description of changes

Some code in haskellPackages relies on these meta attributes. This change should fix gi-gsk in #321948.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

We'll need to use finalPackage if we want to test for the presence of
pkg-config files via passthru.tests.
@sternenseemann sternenseemann requested a review from dotlambda July 14, 2024 21:51
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 14, 2024
@dotlambda
Copy link
Member

Result of nixpkgs-review pr 327213 run on x86_64-linux 1

4 packages failed to build:
  • haskellPackages.gi-adwaita
  • haskellPackages.gi-adwaita.doc
  • haskellPackages.gi-gtk_4 (haskellPackages.gi-gtk_4_0_9)
  • haskellPackages.gi-gtk_4.doc (haskellPackages.gi-gtk_4_0_9.doc)
19 packages built:
  • haskellPackages.ghcjs-dom-hello
  • haskellPackages.ghcjs-dom-hello.data
  • haskellPackages.ghcjs-dom-hello.doc
  • haskellPackages.gi-gdk_4 (haskellPackages.gi-gdk_4_0_8)
  • haskellPackages.gi-gdk_4.doc (haskellPackages.gi-gdk_4_0_8.doc)
  • haskellPackages.gi-gsk
  • haskellPackages.gi-gsk.doc
  • haskellPackages.gi-javascriptcore
  • haskellPackages.gi-javascriptcore.doc
  • haskellPackages.gi-webkit2
  • haskellPackages.gi-webkit2.doc
  • haskellPackages.jsaddle-hello
  • haskellPackages.jsaddle-hello.doc
  • haskellPackages.jsaddle-webkit2gtk
  • haskellPackages.jsaddle-webkit2gtk.doc
  • haskellPackages.reflex-dom
  • haskellPackages.reflex-dom.doc
  • haskellPackages.webkit2gtk3-javascriptcore
  • haskellPackages.webkit2gtk3-javascriptcore.doc

@dotlambda dotlambda merged commit ab294b5 into NixOS:master Jul 18, 2024
@sternenseemann sternenseemann deleted the lerc-pkg-config branch September 1, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants