Conversation
github-actions
bot
added
6.topic: python
Contributor
|
Hi, the parsec-bin version that is currently on nixpkgs does not support ffmpeg_6 and above yet. I have already poked upstream to bump their package to atleast -94 (introduces ffmpeg 6 support), which they said they will do soon. Due to their auto update mechanism you could use the newer one after the client decides to update. I put this on hold until they bump the base version above that. Also the libav and cuda issues can be ignored, they are caused due to parsec querying all versions and picking whatever works. |
Member
Author
|
Thanks for the very quick reply! I had someone try running |
Contributor
|
Parsec should be fine with ffmpeg 4 until they decide to bump. During testing you probably caught the updated version (due to their autoupdater), however that differs from the version that is on nixpkgs currently |
Member
Author
|
Makes sense, thank you. Let’s downgrade it for now and you can bump it when they update their package. Do you know if the new version works with FFmpeg 7.x? |
Contributor
|
It does not support ffmprg 7 yet |
Member
Author
|
I guess that’s to be expected when they haven’t yet made a proper release for an FFmpeg version from 1.5 years ago… Thanks again for the information! Looks like we might have to keep |
ofborg
bot
added
the
8.has: clean-up
ofborg
bot
requested review from
Misterio77,
arcnmx,
junjihashimoto,
pabloaul and
rycee
ofborg
bot
added
10.rebuild-darwin: 101-500
Member
Author
|
Result of 16 packages marked as broken and skipped:
1 package blacklisted:
28 packages failed to build:
1003 packages built:
|
Member
Author
|
No regressions vs. Hydra after running a couple of rebuilds. I think this is good to go. Would be good to hear from @Misterio77 about Dim though. |
Member
|
cc @pluiedev @RaghavSood for testing dim |
Atemu
approved these changes
Jul 14, 2024
Member
Atemu
left a comment
Atemu
left a comment
There was a problem hiding this comment.
Diff LGTM, would like to verify that dim works, otherwise the only realistic way to test this is to have it hit unstable.
This should probably also be announced in https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/
Member
Author
|
It‘ll be a little while before the |
jopejoe1
approved these changes
Jul 14, 2024
Member
jopejoe1
left a comment
jopejoe1
left a comment
There was a problem hiding this comment.
Diff LGTM, thanks for the work.
This builds fine with the current FFmpeg for me.
This builds fine with the current FFmpeg for me.
It just uses the command‐line tool, and the test passes.
Their Dockerfile uses Alpine’s ffmpeg package, which is already on 6. They just invoke the command‐line tool and nothing they do looks particularly version‐sensitive.
Pin FFmpeg to 6.x as upstream doesn’t even support 5.x any more. Unfortunately 7.x support is not yet there; I might have to handle it myself when we drop 6.
These don’t seem necessary.
From <https://github.com/russelltg/wl-screenrec/blob/v0.1.3/README.md#from-source-using-cargo>: > Install ffmpeg 6 or later, which is a required dependency. ffmpeg > 5 may work, but is untested (open an issue or PR if you test with > ffmpeg 5 so I can update these docs on if it works or not) I guess it worked… 7.x will need a bump to the ffmpeg-sys-next crate, but see <russelltg/wl-screenrec#77>.
There is an upstream version that supports FFmpeg >= 6, but it’s not available in their distributed package yet. Downgrade the FFmpeg for now until it can be bumped later.
I have no idea if this works.
Officially supported upstream. 7.x might be a bit tricky because it uses a fork of the ffmpeg-sys-next crate.
Member
Author
|
I realized I forgot to update the hash when bumping Fixed that and the release notes conflict. I‘m busy building Chromiums for the |
SuperSandro2000
approved these changes
Jul 15, 2024
Member
|
Thanks a bunch :) |
Member
Author
|
Uh, I actually found out that fixing the PyAV update breaks the build and was working on fixing it, oops. I’ll open another PR ASAP. |
Member
Author
|
#327626 should fix it; running a review now. Back to tackling FFmpeg 4… |
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
One fewer FFmpeg version! Thankfully, it seems like (almost) everything we ship with this has a version that supports at least
ffmpeg_6. Some signs of turmoil on the horizon, as there’ll be Rust dependencies to update and a very widely‐used Python library to patch when we dropffmpeg_6.I’ve run a
nixpkgs-reviewonx86_64-linuxon amaster‐based version of this for everything except the ~900‐package reverse dependency tree ofpython3Packages.av, which I’m going to leave running on the community builder overnight; if not for that, this could targetmaster. I also ran the NixOS tests forfrigateandakkoma.Hopefully we can get
ffmpeg = ffmpeg_7;into the next staging cycle; everything that I didn’t pin specifically toffmpeg_6here should work with that, but I’m hoping that I can patchpython3Packages.avto support 7.x so we can dropffmpeg_6at the same time.@Misterio77 Could you test Dim and make sure stuff that depends on FFmpeg works? That’s the change I’m least sure of here.
cc @Atemu @jopejoe1
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.