Skip to content

ghidra: 11.1.1 -> 11.1.2, upgrade to gradle 8, openjdk 21#326303

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
jchw-forks:update/ghidra
Jul 17, 2024
Merged

ghidra: 11.1.1 -> 11.1.2, upgrade to gradle 8, openjdk 21#326303
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
jchw-forks:update/ghidra

Conversation

@jchv
Copy link
Contributor

@jchv jchv commented Jul 11, 2024

Description of changes

Updates Ghidra from 11.1.1 to 11.1.2. Also, upgrades Ghidra to build and run with Gradle 8 and OpenJDK 21 to match the upstream.

Tested basic functionality on x86-64_linux.

Ghidraninja scripts needs binwalk. With #326295 applied it seems to compile and load up fine. Other plugins are working inside just this PR.

Tested basic functionality on aarch64-darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@jchv
Copy link
Contributor Author

jchv commented Jul 11, 2024

Result of nixpkgs-review pr 326303 run on x86_64-linux 1

4 packages built:
  • ghidra
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@ofborg ofborg bot requested a review from vringar July 11, 2024 13:14
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 11, 2024
@jchv
Copy link
Contributor Author

jchv commented Jul 11, 2024

Result of nixpkgs-review pr 326303 run on aarch64-darwin 1

4 packages built:
  • ghidra
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@jchv
Copy link
Contributor Author

jchv commented Jul 14, 2024

Rebased since #272380 finally landed :)

@jchv
Copy link
Contributor Author

jchv commented Jul 14, 2024

Result of nixpkgs-review pr 326303 run on x86_64-linux 1

5 packages built:
  • ghidra
  • ghidra-extensions.ghidraninja-ghidra-scripts
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@jchv
Copy link
Contributor Author

jchv commented Jul 14, 2024

Result of nixpkgs-review pr 326303 run on aarch64-darwin 1

5 packages built:
  • ghidra
  • ghidra-extensions.ghidraninja-ghidra-scripts
  • ghidra-extensions.gnudisassembler
  • ghidra-extensions.machinelearning
  • ghidra-extensions.sleighdevtools

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4263

@jchv jchv added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jul 17, 2024
@SuperSandro2000 SuperSandro2000 merged commit 7a4f677 into NixOS:master Jul 17, 2024
@jchv jchv deleted the update/ghidra branch September 27, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants