Skip to content

nixVersions.git: pre20240627_b44909ac -> pre20240709_142e566a#326172

Merged
roberth merged 1 commit into
NixOS:masterfrom
emilazy:push-wnxlsqwpuoxu
Jul 11, 2024
Merged

nixVersions.git: pre20240627_b44909ac -> pre20240709_142e566a#326172
roberth merged 1 commit into
NixOS:masterfrom
emilazy:push-wnxlsqwpuoxu

Conversation

@emilazy

@emilazy emilazy commented Jul 10, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description of changes

Bump past the Darwin sandbox fix.

See also: #326153

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
emilazy requested a review from RaitoBezarius as a code owner July 10, 2024 19:29
@emilazy emilazy mentioned this pull request Jul 10, 2024
Merged
13 tasks
@ofborg
ofborg Bot requested review from Artturin, edolstra and lovesegfault July 10, 2024 20:31
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 10, 2024
@emilazy

emilazy commented Jul 10, 2024

Copy link
Copy Markdown
Member Author

Result of nixpkgs-review pr 326172 run on x86_64-linux 1

5 packages built:
  • nixVersions.git
  • nixVersions.git.debug
  • nixVersions.git.dev
  • nixVersions.git.doc
  • nixVersions.git.man

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 10, 2024
@roberth

roberth commented Jul 11, 2024

Copy link
Copy Markdown
Member

Awesome. Thank you @emilazy!

@roberth
roberth merged commit 4ff97dd into NixOS:master Jul 11, 2024
roberth added a commit to NixOS/nix that referenced this pull request Jul 11, 2024
@roberth @emilazy
packaging: Set darwinMinVersion to fix x86_64-darwin build
0395ff9 
Ported from NixOS/nixpkgs#326172

Co-authored-by: Emily <vcs@emily.moe>
@roberth roberth mentioned this pull request Jul 11, 2024
Merged
@emilazy
emilazy deleted the push-wnxlsqwpuoxu branch August 26, 2024 01:04
domenkozar pushed a commit to cachix/nix that referenced this pull request Sep 10, 2024
@roberth @emilazy @domenkozar
packaging: Set darwinMinVersion to fix x86_64-darwin build
979e0b4 
Ported from NixOS/nixpkgs#326172

Co-authored-by: Emily <vcs@emily.moe>
domenkozar pushed a commit to cachix/nix that referenced this pull request Sep 10, 2024
@roberth @emilazy @domenkozar
packaging: Set darwinMinVersion to fix x86_64-darwin build
b4d43e1 
Ported from NixOS/nixpkgs#326172

Co-authored-by: Emily <vcs@emily.moe>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth roberth approved these changes
@Ericson2314 Ericson2314 Ericson2314 approved these changes
@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius
@Artturin Artturin Awaiting requested review from Artturin
@edolstra edolstra Awaiting requested review from edolstra
@lovesegfault lovesegfault Awaiting requested review from lovesegfault

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emilazy @roberth @Ericson2314 @wegank