haskellPackages.cpython: pin to python 3.11#325499
Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom Jul 9, 2024
Merged
haskellPackages.cpython: pin to python 3.11#325499maralorn merged 1 commit intoNixOS:haskell-updatesfrom
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
Conversation
sheepforce
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
Member
sternenseemann
left a comment
sternenseemann
left a comment
There was a problem hiding this comment.
Since it's a temporary override, it should go into configuration-common.nix traditionally. Otherwise LGTM.
ofborg
bot
added
10.rebuild-darwin: 1-10
sheepforce
force-pushed
the
haskell-cpython-fix
branch
from
b8391b0 to
ea61ed3
Compare
Member
Author
|
Resolved by zsedem/haskell-cpython#22 and release 3.9.0 on Hackage |
Member
|
Looks good. Extra points if you don’t forget to remove it. :D |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The CPython package breaks with the new Python 3.12 unicode API and requires an upstream fix. For an intermediate solution, I've pinned the Python version to 3.11.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.