haskellPackages.ghc96.singletons-base: unbreak

[mpscholten]

Description of changes

Just saw that my previous singletons fix didn't have any impact on hydra as hydra runs on GHC 9.6. This change also fixes singeltons-base on 9.6.

@maralorn why is hydra only running ghc 9.6. Can we also do CI runs with 9.8?

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[maralorn]

Why is this override in the 9.6 specific file? Wouldn’t it make more sense to do this override once in configuration-common.nix?

@maralorn why is hydra only running ghc 9.6. Can we also do CI runs with 9.8?

Because build capacity is limited we only build and maintain the most essential packages on the non-default ghc versions (currently 9.6). We can opt-in to more jobs for some packages if there is a good reason.

[mpscholten]

singletons-base relies on GHC internals. So often times the versions are broken for different reasons. E.g. the version that is compatible with ghc9.6 has issues with the test suite. The version with ghc9.8 has a working test suite but had other issues (addressed in the previous pr)

[maralorn]

Hm, hm. Not super exited about the dontCheck without a comment, but let’s not waste more cycles on this …