python3*: backport fix for armv7l, aarch64, riscv64#325218
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Jul 7, 2024
Merged
python3*: backport fix for armv7l, aarch64, riscv64#325218mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt merged 1 commit intoNixOS:masterfrom
Conversation
Co-Authored-By: Florian Klink <flokli@flokli.de> Signed-off-by: Yureka <fork-nixpkgs-with@yuka.dev>
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 0
Member
Author
|
Thanks! |
This was referenced Jul 7, 2024
Member
Please make this sort of thing unconditional on staging after it's merged — unnecessarily conditionally applied patches lead to annoying problems in future — e.g. a patch no longer applying, but not being tested by the person doing the update, or in this case, the list of platforms used in the condition was non-exhaustive, so I just spent a lot of time chasing the same issue for s390. |
Member
Contributor
|
the fix is also required on powerpc, and the conditional patching omits the fix there |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This is https://cyberchaos.dev/yuka/nixpkgs/-/commit/95ac42d878d756122fbd63a1295b89deaeed0a82 cherry-picked, extended for aarch64, and conditionalized on cross to minimize rebuilds.
Fixes #325213.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.