Skip to content

vulkan-headers,vulkan-loader: 1.3.283.0 -> 1.3.289#325038

Closed
fgaz wants to merge 2 commits intoNixOS:stagingfrom
fgaz:vulkan/1.3.289
Closed

vulkan-headers,vulkan-loader: 1.3.283.0 -> 1.3.289#325038
fgaz wants to merge 2 commits intoNixOS:stagingfrom
fgaz:vulkan/1.3.289

Conversation

@fgaz
Copy link
Member

@fgaz fgaz commented Jul 6, 2024

Description of changes

Prerequisite for packaging vulkan-enabled skia 124, which is itself a prerequisite for updating ladybird, which I maintain

edit: this wasn't actually needed. I have no idea why I thought it was, maybe I confused a different vulkan error

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from Ralith July 6, 2024 14:14
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 6, 2024
@AndersonTorres
Copy link
Member

Have you considered migrating them to by-name?

@fgaz
Copy link
Member Author

fgaz commented Jul 6, 2024

Have you considered migrating them to by-name?

Won't the automatic migration take care of that? I thought we weren't supposed to migrate manually.

@JohnRTitor
Copy link
Member

Won't the automatic migration take care of that? I thought we weren't supposed to migrate manually.

Technically it is allowed to migrate them manually, but only during update PRs or fixing other stuff.

@AndersonTorres
Copy link
Member

AndersonTorres commented Jul 6, 2024

Won't the automatic migration take care of that? I thought we weren't supposed to migrate manually.

The manual migration is allowed in a PR in which another modification takes place.
Updates and refactors are the best opportunity for this.
(This can be useful, since the recent merge bot can merge updates from Ryanbot inside by-name hierarchy.)

Besides it, the mere migration of files is not recommended.

@Ralith
Copy link
Contributor

Ralith commented Jul 6, 2024

Usually we try to keep the whole Vulkan SDK family in sync, e.g. #281591

@fgaz
Copy link
Member Author

fgaz commented Jul 6, 2024

I was just informed about the vulkan version tagging scheme. This PR updates vulkan to a regular release, not a SDK. Is that fine or should we wait?

@AndersonTorres
Copy link
Member

Given the mass-rebuild, I would wait.

@fgaz
Copy link
Member Author

fgaz commented Jul 6, 2024

Makes sense, closing.

@fgaz fgaz closed this Jul 6, 2024
@fgaz fgaz deleted the vulkan/1.3.289 branch July 6, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants