vulkan-headers,vulkan-loader: 1.3.283.0 -> 1.3.289#325038
vulkan-headers,vulkan-loader: 1.3.283.0 -> 1.3.289#325038fgaz wants to merge 2 commits intoNixOS:stagingfrom
Conversation
|
Have you considered migrating them to by-name? |
Won't the automatic migration take care of that? I thought we weren't supposed to migrate manually. |
Technically it is allowed to migrate them manually, but only during update PRs or fixing other stuff. |
The manual migration is allowed in a PR in which another modification takes place. Besides it, the mere migration of files is not recommended. |
|
Usually we try to keep the whole Vulkan SDK family in sync, e.g. #281591 |
|
I was just informed about the vulkan version tagging scheme. This PR updates vulkan to a regular release, not a SDK. Is that fine or should we wait? |
|
Given the mass-rebuild, I would wait. |
|
Makes sense, closing. |
Description of changes
Prerequisite for packaging vulkan-enabled skia 124, which is itself a prerequisite for updating ladybird, which I maintain
edit: this wasn't actually needed. I have no idea why I thought it was, maybe I confused a different vulkan error
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.