Skip to content

Comments

flaresolverr: init at 3.3.21 + nixos/flaresolverr: initial commit#324894

Merged
K900 merged 6 commits intoNixOS:masterfrom
paveloom:flaresolverr
Jul 20, 2024
Merged

flaresolverr: init at 3.3.21 + nixos/flaresolverr: initial commit#324894
K900 merged 6 commits intoNixOS:masterfrom
paveloom:flaresolverr

Conversation

@paveloom
Copy link
Member

@paveloom paveloom commented Jul 5, 2024 •
edited
Loading

Description of changes

https://github.com/FlareSolverr/FlareSolverr
https://github.com/ultrafunkamsterdam/undetected-chromedriver

Closes #294789.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@paveloom paveloom requested a review from natsukium as a code owner July 5, 2024 20:15
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog This PR adds or changes release notes 8.has: module (update) This PR changes an existing module in `nixos/` labels Jul 5, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 5, 2024
@h7x4 h7x4 added 8.has: module (new) This PR adds a module in `nixos/` 8.has: tests This PR has tests labels Jul 6, 2024
LilleAila
LilleAila suggested changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@LilleAila LilleAila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 7, 2024
aanderse
aanderse previously requested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left a review on the nixos module - i hope you find the comments useful

natsukium
natsukium previously requested changes Jul 7, 2024
View reviewed changes
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 8, 2024
@aanderse
Copy link
Member

aanderse commented Jul 9, 2024

changes to the module look good 👍

K900
K900 reviewed Jul 17, 2024
View reviewed changes
K900
K900 reviewed Jul 17, 2024
View reviewed changes
K900
K900 reviewed Jul 17, 2024
View reviewed changes
K900
K900 reviewed Jul 17, 2024
View reviewed changes
@K900
Copy link
Contributor

K900 commented Jul 17, 2024

I now have a branch with all of those changes and chromedriver building from source, which lets flaresolverr run and (somewhat) work on aarch64-linux: https://github.com/K900/nixpkgs/tree/flaresolverr

@paveloom
Copy link
Member Author

paveloom commented Jul 19, 2024

@K900 Pulled in your commits. Thanks!

@K900
Copy link
Contributor

K900 commented Jul 19, 2024

r? emily, nwex for chromedriver changes

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 19, 2024
networkException
networkException reviewed Jul 19, 2024
View reviewed changes
@K900 K900 dismissed stale reviews from aanderse and natsukium July 20, 2024 08:05

Addressed

@K900
Copy link
Contributor

K900 commented Jul 20, 2024

All right, let's get this merged.

@K900 K900 merged commit 5e13e3e into NixOS:master Jul 20, 2024
@paveloom paveloom deleted the flaresolverr branch July 20, 2024 08:54
@akho akho mentioned this pull request Aug 6, 2024
Closed
@emilylange emilylange mentioned this pull request Nov 21, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@K900 K900 K900 left review comments

@aanderse aanderse aanderse left review comments

@natsukium natsukium natsukium left review comments

@emilylange emilylange Awaiting requested review from emilylange

+2 more reviewers

@networkException networkException networkException left review comments

@LilleAila LilleAila LilleAila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: changelog This PR adds or changes release notes 8.has: clean-up This PR removes packages or removes other cruft 8.has: documentation This PR adds or changes documentation 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 8.has: tests This PR has tests 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Package request: FlareSolverr

8 participants

@paveloom @aanderse @K900 @natsukium @networkException @LilleAila @wegank @h7x4