Skip to content

wolfssl: Disable zerocallusedregs hardening on aarch64-darwin.#324515

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
vifino:wolfssl-fix-hardening
Jul 4, 2024
Merged

wolfssl: Disable zerocallusedregs hardening on aarch64-darwin.#324515
vcunat merged 1 commit intoNixOS:staging-nextfrom
vifino:wolfssl-fix-hardening

Conversation

@vifino
Copy link
Member

@vifino vifino commented Jul 4, 2024

Description of changes

@vcunat This fixes the segfaulting test issue. Hope targeting staging-next is correct.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 4, 2024
@vifino vifino requested a review from vcunat July 4, 2024 09:23
@ofborg ofborg bot requested a review from fabaff July 4, 2024 09:50
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 4, 2024
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. /cc PR #316761

@vcunat vcunat mentioned this pull request Jul 4, 2024
2 tasks
@vcunat vcunat merged commit 8f211a9 into NixOS:staging-next Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments