Skip to content

apptainer: 1.3.2 -> 1.3.3#324415

Merged
drupol merged 1 commit into
NixOS:masterfrom
GaetanLepage:apptainer
Jul 4, 2024
Merged

apptainer: 1.3.2 -> 1.3.3#324415
drupol merged 1 commit into
NixOS:masterfrom
GaetanLepage:apptainer

Conversation

@GaetanLepage

@GaetanLepage GaetanLepage commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

Description of changes

Changelog: https://github.com/apptainer/apptainer/releases/tag/v1.3.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage

Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 324415 run on aarch64-darwin 1

@GaetanLepage

Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 324415 run on x86_64-darwin 1

@GaetanLepage

Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 324415 run on x86_64-linux 1

2 packages built:
  • apptainer
  • apptainer-overriden-nixos

@GaetanLepage

Copy link
Copy Markdown
Contributor Author

Result of nixpkgs-review pr 324415 run on aarch64-linux 1

2 packages built:
  • apptainer
  • apptainer-overriden-nixos

@GaetanLepage

Copy link
Copy Markdown
Contributor Author

apptainer.tests builds fine on both aarch64-linux and x86_64-linux.

@ofborg
ofborg Bot requested a review from jbedo July 3, 2024 22:32
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 3, 2024
@GaetanLepage

Copy link
Copy Markdown
Contributor Author

cc @ShamrockLee

@ShamrockLee

ShamrockLee commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

I'll test it later today.

@ShamrockLee

ShamrockLee commented Jul 4, 2024

Copy link
Copy Markdown
Contributor

It turns out that I didn't my laptop with me.

@GaetanLepage Could you help test the image-running functionality? It can be done with the image built in the tests.image-hello-cowsay.

"$(nix-build -A apptainer)/bin/apptainer" exec "$(nix-build apptainer.tests.image-hello-cowsay)" hello

@GaetanLepage

Copy link
Copy Markdown
Contributor Author

Could you help test the image-running functionality?

Done ! It works fine.

@ShamrockLee ShamrockLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the hashes manually. LGTM!

I also hope to backport this version bump. As Apptainer and SingularityCE receives security updates from time to time, it would make security update backporting easier if we backport all the non-major version bumps to the stable branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants