linux: move hexdump to nativeBuildInputs#324322
Merged
JohnRTitor merged 1 commit intoNixOS:stagingfrom Jul 3, 2024
Merged
Conversation
Trying to build vmlinuz.efi natively on aarch64 fails to find hexdump. This was introduced in NixOS#277975. Moving hexdump to nativeBuildInputs fixes the build.
ofborg
bot
requested review from
Ma27,
NeQuissimus,
TredwellGit and
thoughtpolice
ofborg
bot
added
10.rebuild-darwin: 1-10
Contributor
|
Would be nice to get this into staging-next so it gets merged into master at the same time as #277975! |
Member
|
Feel free to cherry pick the changes. |
Contributor
This will probably be fine given that #239721 just got merged to staging as well, so unlikely to cause problems for users anyways, unless they are opting in to using zboot kernel images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Trying to build vmlinuz.efi natively on aarch64 fails to find hexdump. This was introduced in #277975. Moving hexdump to nativeBuildInputs fixes the build.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.