aider-chat: init at 0.50.0 + python3Packages.pypager: init at 3.0.1 by taha-yassine · Pull Request #323927 · NixOS/nixpkgs

taha-yassine · 2024-07-02T01:52:52Z

Description of changes

Things done

Add a 👍 reaction to pull requests you find important.

eclairevoyant

Thanks for the contribution! Some feedback below; I avoided repeating any feedback, but most of these apply to all the files.

pkgs/top-level/all-packages.nix

pkgs/tools/llm/aider/default.nix

pkgs/development/python-modules/grep-ast/default.nix

taha-yassine · 2024-07-02T20:58:12Z

Thanks for the feedback! Should be fine now.

JohnRTitor · 2024-07-15T17:06:03Z

Result of nixpkgs-review pr 323927 run on x86_64-linux 1

4 packages marked as broken and skipped:

aider
aider.dist
python311Packages.grep-ast
python311Packages.grep-ast.dist

KenMacD · 2024-08-01T14:07:51Z

A related PR adds grep-ast: #331173

Sigmanificient · 2024-08-03T03:11:51Z

Hi @taha-yassine, I've ported aider on 0.47.0 (released only a few days ago) in a branch of my nixpkgs fork.

I think it is worth checking out, as it adds a bunch of changes such as using pyproject, replacing
python3.pkgs with python311Packages (pinned due to tree-sitter not supported on python3.12) and other minor changes.

Most importantly, I was able to enables testing, with only a couple of deselected tests.
Feel free to takes this edits to add them here

PS: welcome from a rennais!

nixos-discourse · 2024-08-03T03:18:25Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/50-packaging-bound-aider/49867/18

akaihola · 2024-08-03T12:14:59Z

tree-sitter not supported on python3.12

@Sigmanificient, I do see Python 3.12 Linux wheels on the tree-sitter 0.12.3 PyPI downloads page – this is the tree-sitter version which Aider 0.47.1 requires.

Based on taha-yassine's work (NixOS#323927) but porting a more recent version of the package. Features a bunch of changes such as using pyproject, replacing python3.pkgs with python311Packages (pinned due to treesitting not supported on python3.12). Enables testing, with a couple of deselected tests Co-Authored-by: taha-yassine <taha.yssne@gmail.com>

pkgs/development/python-modules/grep-ast/default.nix

pkgs/by-name/ai/aider/package.nix

pkgs/development/python-modules/grep-ast/default.nix

pkgs/by-name/ai/aider/package.nix

pkgs/development/python-modules/grep-ast/default.nix

greg-hellings · 2024-08-05T01:43:20Z

My grep-ast package was just merged earlier today. I'm also toiling to get aider build. By now it's at 0.47.1 and requires lox, which my PR for is still pending.

taha-yassine · 2024-08-06T02:54:19Z

@Sigmanificient thanks a lot for your work, it was very helpful :)

@greg-hellings lox is a dev dependency and only needed for running a benchmark upstream, so it isn't needed here imo

PR is ready again for review now that grep-ast has been merged

@Sigmanificient @greg-hellings do you want to be added as maintainers as well?

drupol · 2024-08-14T00:15:09Z

As pointed out by @greg-hellings, since new versions are frequent (this PR started at version 0.41.0), maybe we should prioritize getting this one merged first?

I would prefer to update to the very latest, I'll actively follow the development of this thread tomorrow and merge it if CI is green.

taha-yassine · 2024-08-14T00:23:27Z

As pointed out by @greg-hellings, since new versions are frequent (this PR started at version 0.41.0), maybe we should prioritize getting this one merged first?

I would prefer to update to the very latest, I'll actively follow the development of this thread tomorrow and merge it if CI is green.

In that case should I add pypager as part of this PR or open a new one? Maybe @KenMacD wants to take the initiative?

drupol · 2024-08-14T00:24:53Z

It can be part of this PR as long as the commit log message is properly formatted (python311Packages.pypager: init at ...).

taha-yassine · 2024-08-14T02:00:36Z

jiter is an indirect dependency added by the latest version of openai. Should we wait for this PR #332797 to get merged or add it as an explicit dependency here?

NixOS/nixpkgs#323927

taha-yassine · 2024-08-14T12:28:59Z

jiter is an indirect dependency added by the latest version of openai. Should we wait for this PR #332797 to get merged or add it as an explicit dependency here?

Added jiter as a dependency but can remove it if the other PR gets merged in the mean time.

drupol

Added 2 minor comments.

Make to pass only the new files through nixfmt-rfc-style, ignore if it is already done.

pkgs/development/python-modules/pypager/default.nix

drupol · 2024-08-14T13:00:04Z

   error: evaluation aborted with the following error message: 'lib.customisation.callPackageWith: Function called without required argument "prompt_toolkit" at /ofborg/checkout/2/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-1/pkgs/development/python-modules/pypager/default.nix:6, did you mean "prompt-toolkit"?'

pkgs/development/python-modules/pypager/default.nix

pkgs/by-name/ai/aider-chat/package.nix

pkgs/development/python-modules/pypager/default.nix

viraptor · 2024-08-15T00:33:16Z

Well done @taha-yassine - this was a lot more work than a new package usually requires. Great job sticking around to polish it / deal with all the requests. ❤️

taha-yassine · 2024-08-15T16:15:00Z

Well done @taha-yassine - this was a lot more work than a new package usually requires. Great job sticking around to polish it / deal with all the requests. ❤️

I was merely the one who started the PR. I wouldn't have made it this far without the help of everyone that was involved. Thanks everyone! 😊

With thanks to: - NixOS/nixpkgs#323927 - Aider-AI/aider#544

github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Jul 2, 2024

taha-yassine changed the title ~~aider: init at 0.14.2~~ aider: init at 0.41.0 Jul 2, 2024

taha-yassine mentioned this pull request Jul 2, 2024

aider: init at 0.14.2 #260280

Closed

12 tasks

eclairevoyant reviewed Jul 2, 2024

View reviewed changes

taha-yassine force-pushed the aider branch from 2187c05 to 694f1f2 Compare July 2, 2024 20:51

eclairevoyant previously requested changes Aug 3, 2024

View reviewed changes

eclairevoyant reviewed Aug 3, 2024

View reviewed changes

pkgs/by-name/ai/aider/package.nix Outdated Show resolved Hide resolved

eclairevoyant reviewed Aug 3, 2024

View reviewed changes

pkgs/by-name/ai/aider/package.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/grep-ast/default.nix Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

taha-yassine force-pushed the aider branch from 694f1f2 to e3854e1 Compare August 6, 2024 02:43

github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 6, 2024

taha-yassine force-pushed the aider branch from e3854e1 to 63ca8f5 Compare August 6, 2024 02:48

eclairevoyant changed the title ~~aider: init at 0.41.0~~ aider: init at 0.47.0 Aug 6, 2024

smantzavinos added a commit to smantzavinos/aider_flake that referenced this pull request Aug 14, 2024

Working. Copied code from nixpkgs PR.

cd0431b

NixOS/nixpkgs#323927

taha-yassine force-pushed the aider branch from 19acdab to 7bd6dcc Compare August 14, 2024 12:24

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 14, 2024

taha-yassine force-pushed the aider branch from 7bd6dcc to 77c7979 Compare August 14, 2024 12:27

taha-yassine changed the title ~~aider-chat: init at 0.48.0~~ aider-chat: init at 0.50.0 + python3Packages.pypager: init at 3.0.1 Aug 14, 2024

drupol requested changes Aug 14, 2024

View reviewed changes

pkgs/development/python-modules/pypager/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/pypager/default.nix Outdated Show resolved Hide resolved

taha-yassine force-pushed the aider branch from 77c7979 to 1cf9643 Compare August 14, 2024 13:56

natsukium reviewed Aug 14, 2024

View reviewed changes

pkgs/development/python-modules/pypager/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/pypager/default.nix Outdated Show resolved Hide resolved

taha-yassine force-pushed the aider branch from 1cf9643 to 1a25456 Compare August 14, 2024 14:35

natsukium reviewed Aug 14, 2024

View reviewed changes

pkgs/by-name/ai/aider-chat/package.nix Outdated Show resolved Hide resolved

drupol requested changes Aug 14, 2024

View reviewed changes

pkgs/development/python-modules/pypager/default.nix Outdated Show resolved Hide resolved

taha-yassine added 2 commits August 14, 2024 20:13

maintainers: add taha-yassine

8cb8ba0

aider-chat: init at 0.50.0

122892a

taha-yassine force-pushed the aider branch from 1a25456 to 122892a Compare August 14, 2024 18:16

drupol approved these changes Aug 14, 2024

View reviewed changes

ofborg bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 14, 2024

drupol merged commit fcfa553 into NixOS:master Aug 14, 2024

This was referenced Aug 15, 2024

Package request: aider #330726

Closed

[request] Add to nixpkgs Aider-AI/aider#544

Closed

taha-yassine deleted the aider branch August 15, 2024 16:17

mjrusso added a commit to mjrusso/nixos-config that referenced this pull request Aug 20, 2024

Install Aider.

99bab7f

With thanks to: - NixOS/nixpkgs#323927 - Aider-AI/aider#544

Uh oh!

Conversation

taha-yassine commented Jul 2, 2024

Description of changes

Things done

Uh oh!

eclairevoyant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

taha-yassine commented Jul 2, 2024

Uh oh!

JohnRTitor commented Jul 15, 2024

Uh oh!

KenMacD commented Aug 1, 2024

Uh oh!

Sigmanificient commented Aug 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nixos-discourse commented Aug 3, 2024

Uh oh!

akaihola commented Aug 3, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

greg-hellings commented Aug 5, 2024

Uh oh!

taha-yassine commented Aug 6, 2024

Uh oh!

drupol commented Aug 14, 2024

Uh oh!

taha-yassine commented Aug 14, 2024

Uh oh!

drupol commented Aug 14, 2024

Uh oh!

taha-yassine commented Aug 14, 2024

Uh oh!

taha-yassine commented Aug 14, 2024

Uh oh!

drupol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

drupol commented Aug 14, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

viraptor commented Aug 15, 2024

Uh oh!

taha-yassine commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Sigmanificient commented Aug 3, 2024 •

edited

Loading