Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

j4-dmenu-desktop: mark as linux only #323548

Merged
merged 1 commit into from
Jun 30, 2024
Merged

Conversation

Guanran928
Copy link
Contributor

Description of changes

A program that scans .desktop files, doesn't seem to be actually available on darwin.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Guanran928 Guanran928 changed the title j4-demu-desktop: mark as linux only j4-dmemu-desktop: mark as linux only Jun 30, 2024
@Guanran928
Copy link
Contributor Author

for #323144

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 30, 2024
@wegank wegank merged commit 4495eaa into NixOS:master Jun 30, 2024
24 checks passed
@wegank wegank changed the title j4-dmemu-desktop: mark as linux only j4-dmenu-desktop: mark as linux only Jun 30, 2024
@meator
Copy link
Contributor

meator commented Jul 9, 2024

What's wrong with j4-dmenu-desktop on darwin?

@Guanran928
Copy link
Contributor Author

What's wrong with j4-dmenu-desktop on darwin?

Hi, it was failing to compile on Hydra, and I don't think macOS uses the .desktop file approach for launching desktop applications, therefore I disabled it for darwin.

@meator
Copy link
Contributor

meator commented Jul 9, 2024

Ah, thanks. The build error should be fixable by passing -DUSE_KQUEUE=ON. I have never used macOS, so I don't know whether it uses .desktop files or not. The Meson buildsystem has better auto-detection of inotify/kqueue, I believe it could pick it up automatically without overriding anything.

@Guanran928 Guanran928 deleted the j4-dmenu-desktop branch October 20, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants