Skip to content

Comments

lnav: 0.11.2 -> 0.12.2; removed outdated patch#323321

Merged
marcusramberg merged 1 commit intoNixOS:masterfrom
kashw2:lnav
Jun 29, 2024
Merged

lnav: 0.11.2 -> 0.12.2; removed outdated patch#323321
marcusramberg merged 1 commit intoNixOS:masterfrom
kashw2:lnav

Conversation

@kashw2
Copy link
Contributor

@kashw2 kashw2 commented Jun 29, 2024

Description of changes

closes #323245

https://github.com/tstack/lnav/releases/tag/v0.12.2

in order to make this build, I've had to remove the patch that disabled a docs generation. I haven't noticed much of a 'increase' in build time for the package though.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 29, 2024
@marcusramberg
Copy link
Contributor

Result of nixpkgs-review pr 323321 run on x86_64-linux 1

1 package built:
  • lnav

@marcusramberg
Copy link
Contributor

lgtm, thanks :)

@marcusramberg marcusramberg merged commit bca7738 into NixOS:master Jun 29, 2024
@kashw2 kashw2 deleted the lnav branch June 29, 2024 09:27
@wegank wegank mentioned this pull request Jul 3, 2024
13 tasks
@tstack
Copy link

tstack commented Jul 3, 2024

It would be good to add deps for libarchive and cargo/rust since that will enable some more features.

@pcasaretto
Copy link
Contributor

@tstack did just that for cargo/rust on #349284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update request: lnav 0.11.2 → 0.12.2

4 participants