stash: refactor; 0.25.1 -> 0.27.2; nixos/stash: init

[DrakeTDL]

Description of changes

This Pull Request:

• Adds myself as a maintainer
• Refactors Stash to use Git source instead of the binary releases
• Updates version to latest version
  • Changes between releases
  • https://github.com/stashapp/stash/releases/tag/v0.27.2
• Add module
• Add tests

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[DrakeTDL]

Thanks for the review.

[SuperSandro2000]

Please familiarize yourself with the contributing guide https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md especially on how to name commits. It is appreciated that you try to do tiny commits but probably some of those 24 commits could be combined to make this PR not look as daunting.

[DrakeTDL]

Please familiarize yourself with the contributing guide https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md especially on how to name commits. It is appreciated that you try to do tiny commits but probably some of those 24 commits could be combined to make this PR not look as daunting.

@SuperSandro2000
Squashed those commits into the first 4.
Should I also squash the update commit into the refactor commit or is it okay as is?

[Retrodynen]

Anything else needed for this to be merged?

[phanirithvij]

has newer version 0.27.2

[phanirithvij]

suggestion: run these in your local checkout

# minor style improvments
echo nixos/tests/stash.nix pkgs/by-name/st/stash/package.nix nixos/modules/services/web-apps/stash.nix | xargs -n1 nix shell nixpkgs#statix.out -c statix check

# this is good (for this pr)
nix shell nixpkgs#deadnix.out -c deadnix nixos/tests/stash.nix pkgs/by-name/st/stash/package.nix nixos/modules/services/web-apps/stash.nix

just a suggestion, also fyi I don't have commiter access.

[DrakeTDL]

Thanks, I'll definitely use them. I believe I fixed most/all of Sandro's suggestions.

[DrakeTDL]

@phanirithvij What would be the next steps to get this merged? Should I re-submit to discourse/matrix "ready for review" and wait?

[phanirithvij]

ran nixosTest locally, LGTM

[phanirithvij]

@DrakeTDL yes

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4843

[phanirithvij]

any particular reason for this overrideAttrs? can put passthru in buildGoModule itself.

also maybe add passthru.frontend = ui; so people have the ability to override ui build from outside. eg.

nixpkgs/pkgs/by-name/op/opengist/package.nix

Line 79 in d29066d

inherit frontend;

and https://github.com/phanirithvij/system/blob/eca1177e783d5a513ee380892e3ac54dbafff63a/nixos/applications/opengist.nix#L74

[DrakeTDL]

any particular reason for this overrideAttrs? can put passthru in buildGoModule itself.

I initially did that because buildGoModule didn't accept a fixed-point function and I didn't think that I could request itself from the arguments. Don't know why I thought that since it is a package like any other.

As suggested, I inlined passthru and inherited frontend.