Skip to content

nixVersions.git: Fix version and test it#323140

Merged
Artturin merged 2 commits into
NixOS:masterfrom
hercules-ci:fix-nixVersions-git-version
Jul 2, 2024
Merged

nixVersions.git: Fix version and test it#323140
Artturin merged 2 commits into
NixOS:masterfrom
hercules-ci:fix-nixVersions-git-version

Conversation

@roberth

@roberth roberth commented Jun 28, 2024

Copy link
Copy Markdown
Member

Description of changes

  • Fix version
  • test it

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@roberth
roberth requested a review from fricklerhandwerk June 28, 2024 12:43
@roberth
roberth requested a review from RaitoBezarius as a code owner June 28, 2024 12:43
@roberth

roberth commented Jun 28, 2024

Copy link
Copy Markdown
Member Author

@ofborg build nix
@ofborg build nixVersions.nix_2_18
@ofborg build nixVersions.nix_2_19
@ofborg build nixVersions.nix_2_20
@ofborg build nixVersions.nix_2_21
@ofborg build nixVersions.nix_2_22
@ofborg build nixVersions.nix_2_23
@ofborg build nixVersions.git

@ofborg
ofborg Bot requested review from Artturin, edolstra and lovesegfault June 28, 2024 13:32
@ofborg ofborg Bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 28, 2024
@Artturin
Artturin merged commit 4e8d08a into NixOS:master Jul 2, 2024
@github-actions

github-actions Bot commented Jul 2, 2024

Copy link
Copy Markdown
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-323140-to-release-24.05 origin/release-24.05
cd .worktree/backport-323140-to-release-24.05
git switch --create backport-323140-to-release-24.05
git cherry-pick -x 5660f47241d250b7c0bfa7759df6abca93148208 42877a5b2cb5867b5ae3c691add25c05cc69dccb

@Artturin

Artturin commented Jul 3, 2024

Copy link
Copy Markdown
Member

backport #324408

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants