-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linux: enable CONFIG_BT_HCIUART_BCM #322964
Conversation
Add linux kernel support for Broadcom Bluetooth HCI_SERIAL Interface. This will unlock on-board Bluetooth for some 2016-2019 Apple Intel Hardware Series (iMac, MacBookAir, MacBookPro) - tested on MacBookPro14,1
This seems like a pretty heavy rebuild load for a merge into master. I have a feeling this would be better off going into staging, unless you chose master deliberately? |
Search this page for the term "staging" for more information on the distinction between the two: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md It also contains important instructions on how to rebase (not the usual way!) to avoid a mass ping of all contributors. |
To avoid to mess-up a re-base, I closed (without further notice / silently) directly the first PR, after the request to re-write the commit message arrived. Thank you for your (kind) support - and the tip with the staging branch! (Next PR will definitely go there first. But I will RTFM first.) |
I don't know what happened in another PR so forgive me if this was covered but what I'm trying to say is: this PR won't get accepted into master, it should be moved into |
Fixed. Thank you for you patience! ( same with similar PR: #322968 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM
In general yes, not quite true for kernel changes we merge to master usually. Yes it's 5000 package changes but it's mostly kernel modules, the expensive part is building the kernels of which we don't have too many and the kernel modules after that build relatively quick. So in future you can keep kernel changes on master as it makes things easier to test |
Thanks @Mic92 , sorry @paepckehh I wasn't aware of this :) |
No problem, always happy to learn new stuff (hydra & your staging process). Should I manually switch back both kern-conf changes from the staging path (stalled anyway there?) to master - for progress? |
It's ok. I have staging now cached on my machine and can test the building kernels now anyhow.
|
Can this be backported to 24.05? |
Description of changes
Add linux kernel support for Broadcom Bluetooth HCI_SERIAL Interface. This will unlock on-board Bluetooth for some 2016-2019 Apple Intel Hardware Series (iMac, MacBookAir, MacBookPro), tested on MacBookPro14,1 - add some comments, reorg
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.