nixos/mpd: Add a settings option per RFC42#322766
Closed
evyatark2 wants to merge 9 commits intoNixOS:masterfrom
Closed
nixos/mpd: Add a settings option per RFC42#322766evyatark2 wants to merge 9 commits intoNixOS:masterfrom
evyatark2 wants to merge 9 commits intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12.first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
wegank
added
the
2.status: merge conflict
ofborg
bot
removed
the
2.status: merge conflict
nixos/modules/services/audio/mpd.nix
Outdated
| @@ -1,4 +1,7 @@ | |||
| { config, lib, pkgs, ... }: | |||
|
|
|||
| with lib; | |||
Member
There was a problem hiding this comment.
Suggested change
| with lib; | |
| inherit (lib) isList isAttrs isBool; |
#208242
Probably you need to inherit even more stuff from lib.
wegank
added
the
2.status: merge conflict
Member
|
There is a merge conflict due to treewide reformatting. See #395247 |
ofborg
bot
removed
the
2.status: merge conflict
Author
|
@FliegendeWurst |
Member
nixpkgs-ci
bot
added
the
2.status: merge conflict
Contributor
|
There are too many merge commits here, and there's merge conflict. I have applied RFC 42 more thoroughly in: |
Contributor
|
Done in #456989 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.