Skip to content

lorri: 1.6.0 -> 1.7.0#322749

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
nyarly:update-lorri
Jul 7, 2024
Merged

lorri: 1.6.0 -> 1.7.0#322749
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
nyarly:update-lorri

Conversation

@nyarly
Copy link
Contributor

@nyarly nyarly commented Jun 26, 2024 •
edited
Loading

Description of changes

1.7.0 supports Flakes
c.f. https://github.com/nix-community/lorri/releases/tag/1.7.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking - not major
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nyarly
(lorri): (1.6.0 -> 1.7.0)
8497f14 
1.7.0 supports Flakes
@nyarly
Copy link
Contributor Author

nyarly commented Jun 26, 2024

@GrahamcOfBorg build lorri.tests

@ofborg ofborg bot requested review from Profpatsch and grahamc June 26, 2024 22:44
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 26, 2024
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jun 27, 2024
@nyarly
Copy link
Contributor Author

nyarly commented Jun 27, 2024

@GrahamcOfBorg build lorri.tests

@nyarly nyarly changed the title (lorri): (1.6.0 -> 1.7.0) lorri: 1.6.0 -> 1.7.0 Jun 27, 2024
@nyarly nyarly added the 8.has: package (update) This PR updates a package to a newer version label Jun 28, 2024
@nixos-discourse
Copy link

nixos-discourse commented Jun 28, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/1016/155

@nixos-discourse
Copy link

nixos-discourse commented Jul 6, 2024

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4201

SuperSandro2000
SuperSandro2000 reviewed Jul 6, 2024
View reviewed changes
SuperSandro2000
SuperSandro2000 requested changes Jul 6, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the contributing guide when naming your commits.

The title is already confirming and the commit messages should just copy that.

@nyarly
lorri: 1.6.0 -> 1.7.0
f00c486 
Removing superfluous binding for `gitRev`
@nyarly nyarly requested a review from SuperSandro2000 July 6, 2024 18:27
@nyarly
Copy link
Contributor Author

nyarly commented Jul 6, 2024

@SuperSandro2000 Sorry about the commit format - I was trying to follow the guide, and () as a template reference wasn't clear. It's been a little while since my last nixpkgs PR.

@SuperSandro2000 SuperSandro2000 merged commit a9c8ff2 into NixOS:master Jul 7, 2024
@github-actions github-actions bot mentioned this pull request Jul 7, 2024
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2024

Successfully created backport PR for release-24.05:

wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Jul 8, 2024
@wolfgangwalther
lorri: fix cargoHash
81e5c46 
This is a mismatch after merging both of:
- NixOS#323983
- NixOS#322749
@wolfgangwalther wolfgangwalther mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

@grahamc grahamc Awaiting requested review from grahamc

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nyarly @nixos-discourse @SuperSandro2000