Skip to content

grist-core: init package and module#322633

Draft
bendlas wants to merge 3 commits intoNixOS:masterfrom
bendlas:init-grist-core
Draft

grist-core: init package and module#322633
bendlas wants to merge 3 commits intoNixOS:masterfrom
bendlas:init-grist-core

Conversation

@bendlas
Copy link
Copy Markdown
Contributor

@bendlas bendlas commented Jun 26, 2024

Description of changes

Packages grist-core, see #295228

Until nixos module is implemented, you can test with

TYPEORM_DATABASE=/tmp/grist/db.sqlite3 GRIST_INST_DIR=/tmp/grist GRIST_DATA_DIR=/tmp/grist/docs $(nix-build . -A grist-core --no-out-link)/bin/grist-run

Things done

  • Packaging Tasks

    • Package node / yarn package
    • Package python dependencies (unsandboxed)
    • Implement sandbox based on gvisor
    • Implement nixos module
    • Add nixos release notes
      • Add support for redis
      • Add support for minio
  • Built on platform(s)

    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:

  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage

  • Tested basic functionality of all binary files (usually in ./result/bin/)

  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.


Add a 👍 reaction to pull requests you find important.

@bendlas bendlas requested a review from eclairevoyant June 26, 2024 12:28
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 26, 2024
@bendlas bendlas changed the title Init grist core grist-core: init package and module Jun 26, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 26, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@Scandiravian
Copy link
Copy Markdown
Contributor

Hi @bendlas

Thanks for working on getting Grist added to nixpkgs. We are looking into using Grist at my org, so I'm curious if you have bandwidth to getting this ready for merge at the moment? Is there anything I can do to help getting the PR to a ready state? I'm able to contribute work hours to working on this if you're interested in that

Once again thanks for the work you've put in so far 😊

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 21, 2025
@bendlas
Copy link
Copy Markdown
Contributor Author

bendlas commented Jan 21, 2025

Hi @Scandiravian,

thanks for offering. I am definitely available for doing code reviews and I'd be willing to help with maintenance once completed.

I am also interested in finishing the implementation (because I want it for my pet project), but that's far from the top of my priorities, right now, though I am available for consulting if your org would like to put it there.

Of course, contributed working hours are welcome with NixOS. I could see myself providing some guidance on top of just reviews, if you want to go that route, depending on how much is needed.

As to what's missing (not necessarily blocking):

  • sandboxing: AFAICT that's the most severe blocker for getting this in
  • A NixOS module
  • Tests
  • An updateScript
  • Nginx integration
  • Database integration
  • ... probably more for production usage

Be aware of this parallel effort here: #305019, which seems to have resolved the first two issues already, from a quick glance. That seems to be a lot further ahead than my PR here, and I'd probably start with comparing and joining PRs.

@Scandiravian Scandiravian mentioned this pull request Jan 23, 2025
13 tasks
@Scandiravian
Copy link
Copy Markdown
Contributor

@bendlas Thanks for taking the time to reply to me. I've created a new PR that combines yours and the one you referenced. If you have time, I'd be happy if you could take a look and see if you're happy with the changes (and that your work is correctly attributed). Any help you can offer would also be greatly appreciated!

There's some failing tests in my PR that I'll try to get fixed tomorrow.

P.S. Your pet project looks super cool. I'll try to look through it more thoroughly when I have the time 😄

@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants