grist-core: init package and module#322633
Conversation
|
Hi @bendlas Thanks for working on getting Grist added to nixpkgs. We are looking into using Grist at my org, so I'm curious if you have bandwidth to getting this ready for merge at the moment? Is there anything I can do to help getting the PR to a ready state? I'm able to contribute work hours to working on this if you're interested in that Once again thanks for the work you've put in so far 😊 |
|
Hi @Scandiravian, thanks for offering. I am definitely available for doing code reviews and I'd be willing to help with maintenance once completed. I am also interested in finishing the implementation (because I want it for my pet project), but that's far from the top of my priorities, right now, though I am available for consulting if your org would like to put it there. Of course, contributed working hours are welcome with NixOS. I could see myself providing some guidance on top of just reviews, if you want to go that route, depending on how much is needed. As to what's missing (not necessarily blocking):
Be aware of this parallel effort here: #305019, which seems to have resolved the first two issues already, from a quick glance. That seems to be a lot further ahead than my PR here, and I'd probably start with comparing and joining PRs. |
|
@bendlas Thanks for taking the time to reply to me. I've created a new PR that combines yours and the one you referenced. If you have time, I'd be happy if you could take a look and see if you're happy with the changes (and that your work is correctly attributed). Any help you can offer would also be greatly appreciated! There's some failing tests in my PR that I'll try to get fixed tomorrow. P.S. Your pet project looks super cool. I'll try to look through it more thoroughly when I have the time 😄 |
Description of changes
Packages grist-core, see #295228
Until nixos module is implemented, you can test with
TYPEORM_DATABASE=/tmp/grist/db.sqlite3 GRIST_INST_DIR=/tmp/grist GRIST_DATA_DIR=/tmp/grist/docs $(nix-build . -A grist-core --no-out-link)/bin/grist-runThings done
Packaging Tasks
Built on platform(s)
For non-Linux: Is sandboxing enabled in
nix.conf? (See Nix manual)sandbox = relaxedsandbox = trueTested, as applicable:
Tested compilation of all packages that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usageTested basic functionality of all binary files (usually in
./result/bin/)24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
Fits CONTRIBUTING.md.
Add a 👍 reaction to pull requests you find important.