Skip to content

nixos/filesystems: guard assertion messages against eval failures#320846

Closed
philiptaron wants to merge 1 commit intoNixOS:masterfrom
philiptaron:filesystems-assertions
Closed

nixos/filesystems: guard assertion messages against eval failures#320846
philiptaron wants to merge 1 commit intoNixOS:masterfrom
philiptaron:filesystems-assertions

Conversation

@philiptaron
Copy link
Copy Markdown
Contributor

Description of changes

The messages for these filesystem assertions ought to be able to be printed even if the assertion condition is not encountered.

I encountered this while testing #313497.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

These messages ought to be able to be printed even if the assertion condition is not encountered.
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 18, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 18, 2024
@ElvishJerricco
Copy link
Copy Markdown
Contributor

ElvishJerricco commented Jun 19, 2024

@philiptaron I really dislike this method of repeating the condition in the message to replace the message with a more nonsense one. I think it would have been better for this to have simply altered the behavior of the assertions option, maybe with an apply setting for the type of message, so that it replaces the message with "assertion not triggered" or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants