nixos/filesystems: guard assertion messages against eval failures#320846
Closed
philiptaron wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos/filesystems: guard assertion messages against eval failures#320846philiptaron wants to merge 1 commit intoNixOS:masterfrom
philiptaron wants to merge 1 commit intoNixOS:masterfrom
Conversation
These messages ought to be able to be printed even if the assertion condition is not encountered.
Contributor
|
@philiptaron I really dislike this method of repeating the condition in the message to replace the message with a more nonsense one. I think it would have been better for this to have simply altered the behavior of the |
13 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The messages for these filesystem assertions ought to be able to be printed even if the assertion condition is not encountered.
I encountered this while testing #313497.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)