nixos/nvidia: move TOPOLOGY_FILE_PATH and DATABASE_PATH into nvidia-fabricmanager service definition#320830
Conversation
… hardware.nvidia.datacenter.settings default into the service file
github-actions
bot
added
6.topic: nixos
philiptaron
requested review from
ConnorBaker,
FireyFly,
Kiskae and
SomeoneSerge
ofborg
bot
added
10.rebuild-darwin: 0
FireyFly
left a comment
FireyFly
left a comment
There was a problem hiding this comment.
Makes sense to me, reducing the scope to one where nvidia_x11 is known to be non-null
wegank
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1787 |
| TOPOLOGY_FILE_PATH = "${nvidia_x11.fabricmanager}/share/nvidia-fabricmanager/nvidia/nvswitch"; | ||
| DATABASE_PATH = "${nvidia_x11.fabricmanager}/share/nvidia-fabricmanager/nvidia/nvswitch"; |
There was a problem hiding this comment.
Side-note: I find these passthru packages in nvidia_x11 rather annoying; we recently found that e.g. libXNctrl could be moved out of nvidia_x11 entirely (#318092); do you know if is fabricmanager driver-locked?
There was a problem hiding this comment.
https://docs.nvidia.com/datacenter/tesla/pdf/fabric-manager-user-guide.pdf
That diagram suggests that it is, sadly, but I don't know for sure.
| # unsuitable to be mentioned in the configuration defaults, but they _can_ | ||
| # be overridden in `cfg.datacenter.settings` if needed. | ||
| fabricManagerConfDefaults = { | ||
| TOPOLOGY_FILE_PATH = "${nvidia_x11.fabricmanager}/share/nvidia-fabricmanager/nvidia/nvswitch"; |
There was a problem hiding this comment.
Sanity-check: here nvidia_x11 != null because it's guarded by cfg.enable?
5 participants
Description of changes
Move the TOPOLOGY_FILE_PATH and DATABASE_PATH keys from
hardware.nvidia.datacenter.settingsdefault into the service file derivation. As can be seen on line 9,nvidia_x11can be null and thus is unsuitable for use in this venue.I discovered this while testing out #313497.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)