Skip to content

treewide: set meta.changelog#320368

Merged
h7x4 merged 1 commit intoNixOS:masterfrom
h7x4:treewide-set-meta-changelog
Jul 7, 2024
Merged

treewide: set meta.changelog#320368
h7x4 merged 1 commit intoNixOS:masterfrom
h7x4:treewide-set-meta-changelog

Conversation

@h7x4
Copy link
Member

@h7x4 h7x4 commented Jun 16, 2024

Description of changes

Set meta.changelog for a few packages around in pkgs/by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 16, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 16, 2024
@h7x4 h7x4 force-pushed the treewide-set-meta-changelog branch 11 times, most recently from b7529b0 to aa25aba Compare June 17, 2024 22:48
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4141

@h7x4 h7x4 force-pushed the treewide-set-meta-changelog branch from aa25aba to 50f43e5 Compare July 1, 2024 18:27
Copy link
Contributor

@marcusramberg marcusramberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I haven't checked all the URLs, but I read through the diff and didn't spot anything unreasonable.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 2.status: merge conflict This PR has merge conflicts with the target branch labels Jul 1, 2024
@h7x4 h7x4 force-pushed the treewide-set-meta-changelog branch from 50f43e5 to 7384b9a Compare July 7, 2024 13:20
@h7x4 h7x4 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 7, 2024
@h7x4 h7x4 merged commit f1139ba into NixOS:master Jul 7, 2024
@h7x4 h7x4 mentioned this pull request Oct 4, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants