Skip to content

[Backport release-24.05] hyprland: 0.40.0-unstable-2024-05-05 -> 0.41.1; hyprwayland-scanner: 0.3.4 -> 0.3.10; hyprlandPlugins.hy3: 0.40.0 -> 0.41.0; hyprutils: init at 0.1.2; hyprlandPlugins: init upstream hyprland-plugins at 0.41.1, hy3: 0.41.0 -> 0.41.1#320347

Merged
JohnRTitor merged 12 commits intoNixOS:release-24.05from
fufexan:backport-319131-to-release-24.05
Jun 23, 2024

Conversation

@fufexan
Copy link
Contributor

@fufexan fufexan commented Jun 16, 2024

Description of changes

Manual backport for #319131, #321069, #309255, #321575.
Also backported hyprcursor-1.9, otherwise Hyprland wouldn't build.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@fufexan fufexan force-pushed the backport-319131-to-release-24.05 branch from 5f1652e to 06501f4 Compare June 16, 2024 20:23
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 16, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jun 16, 2024
Copy link
Member

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes my eyeball test, but CI seems to report an error, not a hard fail though.

@wineee
Copy link
Member

wineee commented Jun 17, 2024

CI fail caused by #317959 , it not backport to release-24.05, cause
meta mismatch

meta = {
          homepage = "https://github.com/hyprwm/hyprwayland-scanner";
    -     description = "Hyprland version of wayland-scanner in and for C++";
    +-    description = "A Hyprland version of wayland-scanner in and for C++";
     -    license = licenses.bsd3;
     -    maintainers = with maintainers; [ fufexan ];
    ++    description = "Hyprland version of wayland-scanner in and for C++";
     +    changelog = "[https://github.com/hyprwm/hyprwayland-scanner/releases/tag/${finalAttrs.version}](https://github.com/hyprwm/hyprwayland-scanner/releases/tag/$%7BfinalAttrs.version%7D)";
     +    license = lib.licenses.bsd3;
     +    maintainers = with lib.maintainers; [ fufexan ];

@fufexan
Copy link
Contributor Author

fufexan commented Jun 17, 2024

So we can't change meta for backports?

@JohnRTitor
Copy link
Member

Could you do a partial backport of the conflicting commit? (of only the Hyprland package)

Else further backports to 24.05 will fail as well.

@fufexan fufexan force-pushed the backport-319131-to-release-24.05 branch 2 times, most recently from 29d5b94 to 1399d89 Compare June 17, 2024 09:31
@fufexan fufexan force-pushed the backport-319131-to-release-24.05 branch from 1399d89 to 8e4fa0d Compare June 17, 2024 09:59
@fufexan
Copy link
Contributor Author

fufexan commented Jun 17, 2024

Ok, I don't know what CI wants me to do. Is there a commit I'm missing?

@ofborg ofborg bot requested a review from JohnRTitor June 17, 2024 11:03
@donovanglover
Copy link
Member

Should be able to fix by removing the meta.description change in 8e4fa0d#diff-be17458e33be77de31b34f9517f70d41b45b6675673dd0174607d8aacc424c48L167

JohnRTitor and others added 6 commits June 17, 2024 17:50
Needed for Hyprland v41.0 release.

(cherry picked from commit 83cc03f)
needed for Hyprland 41.1

Co-authored-by: Donovan Glover <donovan@dglover.co>
(cherry picked from commit 0c723f6)
Co-authored-by: fufexan <mihai@fufexan.net>
(cherry picked from commit 7b13603)
@fufexan fufexan force-pushed the backport-319131-to-release-24.05 branch from 8e4fa0d to f70a62a Compare June 17, 2024 14:51
@JohnRTitor JohnRTitor requested a review from Mic92 June 17, 2024 15:58
@Schweber
Copy link
Contributor

@JohnRTitor hyprutils have been updated to 0.1.3 a few hours ago

@JohnRTitor
Copy link
Member

@JohnRTitor hyprutils have been updated to 0.1.3 a few hours ago

Sure #321069

Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donovanglover donovanglover added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 19, 2024
@wineee
Copy link
Member

wineee commented Jun 20, 2024

hy3-0.41.0 failed to build, https://logs.ofborg.org/?key=nixos/nixpkgs.320347&attempt_id=86365f30-bb52-481c-a60e-612ff1d2c80e

[ 14%] Building CXX object CMakeFiles/hy3.dir/src/dispatchers.cpp.o
[ 28%] Building CXX object CMakeFiles/hy3.dir/src/main.cpp.o
[ 42%] Building CXX object CMakeFiles/hy3.dir/src/Hy3Layout.cpp.o
[ 71%] Building CXX object CMakeFiles/hy3.dir/src/SelectionHook.cpp.o
[ 71%] Building CXX object CMakeFiles/hy3.dir/src/Hy3Node.cpp.o
[ 85%] Building CXX object CMakeFiles/hy3.dir/src/TabGroup.cpp.o
/build/source/src/TabGroup.cpp:14:10: fatal error: src/helpers/memory/SharedPtr.hpp: No such file or directory
   14 | #include "src/helpers/memory/SharedPtr.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

@donovanglover
Copy link
Member

Good catch. Upstream issue: outfoxxed/hy3#120

@wegank wegank added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 20, 2024
Copy link
Member

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include the #321069 backport

And this is blocked until there is a 41.1 release of hy3

(cherry picked from commit dda39b7)
@JohnRTitor
Copy link
Member

I feel like #309255 should be included as well since v0.40 changed the socket address.

@ofborg ofborg bot requested review from JohnRTitor and donovanglover June 20, 2024 14:57
@wegank wegank removed the 12.approvals: 3+ This PR was reviewed and approved by three or more persons. label Jun 21, 2024
(cherry picked from commit 470a554)
@JohnRTitor
Copy link
Member

I have removed the blockers please cherry-pick #321575.

fufexan added 3 commits June 23, 2024 00:35
Format with nixfmt-rfc-style.

(cherry picked from commit 8e6784a)
(cherry picked from commit ef64bb4)
@fufexan fufexan changed the title [Backport release-24.05] hyprland: 0.40.0-unstable-2024-05-05 -> 0.41.1; hyprwayland-scanner: 0.3.4 -> 0.3.10; hyprlandPlugins.hy3: 0.40.0 -> 0.41.0; hyprutils: init at 0.1.2 [Backport release-24.05] hyprland: 0.40.0-unstable-2024-05-05 -> 0.41.1; hyprwayland-scanner: 0.3.4 -> 0.3.10; hyprlandPlugins.hy3: 0.40.0 -> 0.41.0; hyprutils: init at 0.1.2; hyprlandPlugins: init upstream hyprland-plugins at 0.41.1, hy3: 0.41.0 -> 0.41.1 Jun 22, 2024
@JohnRTitor JohnRTitor dismissed their stale review June 23, 2024 02:54

Changes addressed

@JohnRTitor
Copy link
Member

Result of nixpkgs-review pr 320347 run on x86_64-linux 1

26 packages built:
  • grimblast
  • hdrop
  • hyprcursor
  • hyprcursor.dev
  • hyprcursor.lib
  • hyprland
  • hyprland.dev
  • hyprland.man
  • hyprlandPlugins.borders-plus-plus
  • hyprlandPlugins.csgo-vulkan-fix
  • hyprlandPlugins.hy3
  • hyprlandPlugins.hyprbars
  • hyprlandPlugins.hyprexpo
  • hyprlandPlugins.hyprtrails
  • hyprlandPlugins.hyprwinwrap
  • hyprpaper
  • hyprshade
  • hyprshade.dist
  • hyprshot
  • hyprutils
  • hyprutils.dev
  • hyprwayland-scanner
  • nwg-panel
  • nwg-panel.dist
  • waybar
  • xdg-desktop-portal-hyprland

@JohnRTitor JohnRTitor merged commit 347402c into NixOS:release-24.05 Jun 23, 2024
@fufexan fufexan deleted the backport-319131-to-release-24.05 branch June 23, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants