Skip to content

Comments

haskellPackages.html-parse: unbreak#320038

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
slotThe:html-parse-unbreak
Jun 17, 2024
Merged

haskellPackages.html-parse: unbreak#320038
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
slotThe:html-parse-unbreak

Conversation

@slotThe
Copy link
Member

@slotThe slotThe commented Jun 15, 2024

Things done

  • Built on platform(s)

    • x86_64-linux

      $ nix-build ./ -A haskellPackages.html-parse
[…]
/nix/store/g4p8a0i4w51cs297qdmgnmm3kq1bzgm5-html-parse-0.2.1.0

    • aarch64-linux

    • x86_64-darwin

    • aarch64-darwin

  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 15, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 15, 2024
@siraben
Copy link
Member

siraben commented Jun 15, 2024

Result of nixpkgs-review pr 320038 run on x86_64-linux 1

@maralorn
Copy link
Member

maralorn commented Jun 17, 2024

You edited an autogenerate file. Please remove the entry for html-parse from broken.yaml.

@slotThe slotThe force-pushed the html-parse-unbreak branch from 4072836 to 1d68e8d Compare June 17, 2024 08:14
@slotThe
Copy link
Member Author

slotThe commented Jun 17, 2024

Ugh, sorry, I always forget to do that 😞

@maralorn maralorn merged commit eb15303 into NixOS:haskell-updates Jun 17, 2024
@maralorn
Copy link
Member

maralorn commented Jun 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

@ncfavier ncfavier Awaiting requested review from ncfavier

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slotThe @siraben @maralorn