Skip to content

Comments

haskellPackages.push-notify-apn: unbroken#319890

Merged
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
mpscholten:push-notify-apn-unbroken
Jun 17, 2024
Merged

haskellPackages.push-notify-apn: unbroken#319890
maralorn merged 1 commit intoNixOS:haskell-updatesfrom
mpscholten:push-notify-apn-unbroken

Conversation

@mpscholten
Copy link
Contributor

Description of changes

I took over maintainership of this package a while ago and fixed the build errors in the latest hackage release

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 14, 2024
I took over maintainership of this package a while ago and fixed the
build errors in the latest hackage release
@mpscholten mpscholten force-pushed the push-notify-apn-unbroken branch from 24d4277 to ceebde5 Compare June 14, 2024 19:59
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 14, 2024
@maralorn
Copy link
Member

btw. you might be interested in registering as a maintainer for some haskell packages. Have a look at the maintainers section in the Haskell main.yaml file if that is the case.

@maralorn maralorn merged commit 180957a into NixOS:haskell-updates Jun 17, 2024
@maralorn
Copy link
Member

thx!

@mpscholten mpscholten deleted the push-notify-apn-unbroken branch June 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants