electron-source.electron_{27,28}: remove instead of marking them as EOL, remove no longer needed version conditionals#319415
Merged
yu-re-ka merged 2 commits intoNixOS:masterfrom Jun 13, 2024
Conversation
Follow-up to 7892638. We still have the EOLed `electron-{27,28}-bin` builds, that can be used instead. `electron-source.electron_{27,28}` do not build anymore due to LLVM incompatibilities. This is beneficial to users of software that still depend on those EOLed electron versions as well. Instead of wasting potentially hours of compute trying to build known broken versions from source, the working binary variants will be used. Furthermore, this allows us to cleanup the underlying chromium and electron-source derivations from now unused version conditions such as version specific patches and build flags.
The minimum versions for both chromium and electron-source are higher than the version bounds of those conditionals. As such, they can be safely removed. This is a no-op.
27 tasks
ofborg
bot
added
8.has: package (new)
SuperSandro2000
approved these changes
Jun 13, 2024
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
IMO this needs to go into the next cycle together with the linked PR
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Follow-up to #319252 (7892638).
We still have the EOLed
electron-{27,28}-binbuilds, that can be used instead.electron-source.electron_{27,28}do not build anymore due to LLVM incompatibilities.This is beneficial to users of software that still depend on those EOLed electron versions as well.
Instead of wasting potentially hours of compute trying to build known broken versions from source, the working binary variants will be used.
Furthermore, this allows us to cleanup the underlying chromium and electron-source derivations from now unused version conditions such as version specific patches and build flags.
The version conditional cleanup in the second commit is a no-op.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)