bitwarden-desktop: 2024.5.0 -> 2024.6.0#319327
Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom Jun 13, 2024
Merged
Conversation
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
Can you do a me a favor and carry over the other changes from https://github.com/NixOS/nixpkgs/pull/319329/files ? Otherwise LGTM
ofborg
bot
added
11.by: package-maintainer
- Update description to match bitwarden-cli - Prefer `lib.getExe`
Otherwise nothing tells us we are using different than upstream. This also checks anything else in the `package.json`’s `engines` spec, e.g. npm version, which we might not care about but it’s compatible now so it’s fine. See https://docs.npmjs.com/cli/v10/using-npm/config#engine-strict
amarshall
force-pushed
the
bitwarden-update
branch
from
72a21cc to
8b99f45
Compare
Member
Author
|
@SuperSandro2000 Done. Also added another commit since there was nothing to force the Node.js upgrade. I left the maintainer removal out as there is still #319269 |
SuperSandro2000
approved these changes
Jun 13, 2024
Contributor
|
thank you!!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes ready for #319252
Diff: bitwarden/clients@desktop-v2024.5.0...desktop-v2024.6.0
Changelog: https://github.com/bitwarden/clients/releases/tag/desktop-v2024.6.0
Description of changes
Things done
Tested vault sync, copy-paste.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.