Skip to content

Comments

doc/haskell: Dedup and edit justStaticExecutables#319298

Merged
sternenseemann merged 1 commit intoNixOS:masterfrom
hercules-ci:doc-justStaticExecutables
Jun 12, 2024
Merged

doc/haskell: Dedup and edit justStaticExecutables#319298
sternenseemann merged 1 commit intoNixOS:masterfrom
hercules-ci:doc-justStaticExecutables

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jun 12, 2024

Description of changes

Make sure all relevant info is in the user manual and avoid duplication of efforts or things going out of sync.

The feature was introduced in

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Make sure all relevant info is in the user manual and avoid duplication
of efforts, or things going out of sync.
@github-actions github-actions bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: documentation This PR adds or changes documentation labels Jun 12, 2024
other system library dependencies.

If the library being built or its dependencies use their Cabal-generated
If a library or its dependencies use their Cabal-generated
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC the doc team recommends a single line per sentence, so that we don't have to reflow. I haven't done the reflowing to keep the diff readable.

@roberth roberth requested a review from 9999years June 12, 2024 10:51
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 12, 2024
@sternenseemann sternenseemann merged commit 299bd6a into NixOS:master Jun 12, 2024
@sternenseemann
Copy link
Member

May be worth backporting?

@github-actions
Copy link
Contributor

Successfully created backport PR for release-24.05:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants