[staging-next] qt5.qtlocation: fix build on Darwin#319241
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Jun 12, 2024
Merged
[staging-next] qt5.qtlocation: fix build on Darwin#319241vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
Well, "fix", because this just allows us to use deprecated C++ features for now, and the actual consumer of said features is boost 1.65.1, vendored inside mapbox-gl, vendored inside qtlocation, with all the upstreams in this chain being mostly dead. Anyway, this should buy us time until the next libcxx bump comes around, and then we'll have to send qt5location to a farm upstate unless someone wants to go through the entire boost codebase and precision-upgrade it.
github-actions
bot
added
the
6.topic: qt/kde
ofborg
bot
added
10.rebuild-darwin: 101-500
vcunat
pushed a commit
that referenced
this pull request
Jun 23, 2024
Well, "fix", because this just allows us to use deprecated C++ features for now, and the actual consumer of said features is boost 1.65.1, vendored inside mapbox-gl, vendored inside qtlocation, with all the upstreams in this chain being mostly dead. Anyway, this should buy us time until the next libcxx bump comes around, and then we'll have to send qt5location to a farm upstate unless someone wants to go through the entire boost codebase and precision-upgrade it. (cherry picked from commit b6924cd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, "fix", because this just allows us to use deprecated C++ features for now, and the actual consumer of said features is boost 1.65.1, vendored inside mapbox-gl, vendored inside qtlocation, with all the upstreams in this chain being mostly dead.
Anyway, this should buy us time until the next libcxx bump comes around, and then we'll have to send qt5location to a farm upstate unless someone wants to go through the entire boost codebase and precision-upgrade it.
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.