Skip to content

mesa: hack around aarch64-darwin build failure#319108

Merged
K900 merged 1 commit intoNixOS:staging-nextfrom
K900:mesa-fix-but-bad
Jun 11, 2024
Merged

mesa: hack around aarch64-darwin build failure#319108
K900 merged 1 commit intoNixOS:staging-nextfrom
K900:mesa-fix-but-bad

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Jun 11, 2024

Description of changes

This unblocks things now, without having to dig through eval failures on #319047.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 11, 2024
@K900 K900 requested review from reckenrode and vcunat June 11, 2024 18:12
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the current unblocking.

@vcunat
Copy link
Member

vcunat commented Jun 11, 2024

I tried aarch64-darwin build locally.

@K900 K900 merged commit 9e9347a into NixOS:staging-next Jun 11, 2024
@vcunat vcunat mentioned this pull request Jun 11, 2024
13 tasks
@ofborg ofborg bot requested review from primeos and vcunat June 11, 2024 18:42
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 11, 2024
@K900 K900 deleted the mesa-fix-but-bad branch July 27, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants