roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11 #318497

konradmalik · 2024-06-09T09:44:58Z

Description of changes

Updating the package.
Added dotnet sdk 9 and removed all other sdks - whether they're present or not, the app compiles and works the same, and the generated deps.nix are also the same.

Things done

Add a 👍 reaction to pull requests you find important.

konradmalik · 2024-06-09T09:45:59Z

cannot fetch-deps, possible cause? #315574

konradmalik · 2024-06-11T13:42:30Z

eh, current status: linux - works, darwin - build error, reproducible locally with plain dotnet build

Looks like upstream issue: dotnet/roslyn#73439

A part of our log:

  Microsoft.CodeAnalysis.CSharp net8.0 failed with 14333 error(s) (17.5s)
    /private/tmp/nix-build-roslyn-ls-4.11.0-3.24307.2.drv-0/tmp.DDpdZBNUmZ/.nuget/packages/microsoft.net.compilers.toolset/4.11.0-2.24270.4/tasks/netcore/Microsoft.CSharp.Core.targets(85,5): error : Process terminated. System.InsufficientExecutionStackException: Insufficient stack to continue executing the program safely. This can happen from having too many functions on the call stack or function on the stack using too much stack space.
    /private/tmp/nix-build-roslyn-ls-4.11.0-3.24307.2.drv-0/tmp.DDpdZBNUmZ/.nuget/packages/microsoft.net.compilers.toolset/4.11.0-2.24270.4/tasks/netcore/Microsoft.CSharp.Core.targets(85,5): error :    at System.Runtime.CompilerServices.RuntimeHelpers.EnsureSufficientExecutionStack()
    /private/tmp/nix-build-roslyn-ls-4.11.0-3.24307.2.drv-0/tmp.DDpdZBNUmZ/.nuget/packages/microsoft.net.compilers.toolset/4.11.0-2.24270.4/tasks/netcore/Microsoft.CSharp.Core.targets(85,5): error :    at Microsoft.CodeAnalysis.StackGuard.EnsureSufficientExecutionStack(Int32 recursionDepth)
    /private/tmp/nix-build-roslyn-ls-4.11.0-3.24307.2.drv-0/tmp.DDpdZBNUmZ/.nuget/packages/microsoft.net.compilers.toolset/4.11.0-2.24270.4/tasks/netcore/Microsoft.CSharp.Core.targets(85,5): error :    at Microsoft.CodeAnalysis.CSharp.CSharpSyntaxWalker.Visit(SyntaxNode node)

konradmalik · 2024-07-28T13:33:08Z

Because the fix for darwin build in the upstream repo is nowhere in sight, could we try a different approach here?

I have a working example in my personal repo where I install roslyn-ls from the Nuget packages published to this feed - those are official Microsoft builds.

This is the same approach that VSCode's C# Dev Kit extension uses to install this server based on: dotnet/roslyn#71474 (comment)

@SuperSandro2000 could we have something like that in nixpkgs? It would simplify this package quite a bit, but the downside is that we would rely on binary blobs published to nuget. On the other hand, we already rely on them when downloading nuget dependencies for any dotnet project.

FYI: my proposition here: #330683

SuperSandro2000 · 2024-07-28T19:52:12Z

Sounds fine to me

corngood · 2024-07-29T14:27:39Z

I seem to be able to work around the stack overflow error by doing this:

diff --git a/pkgs/by-name/ro/roslyn-ls/deps.nix b/pkgs/by-name/ro/roslyn-ls/deps.nix
index 2bbb08488396..7eb95212be3a 100644
--- a/pkgs/by-name/ro/roslyn-ls/deps.nix
+++ b/pkgs/by-name/ro/roslyn-ls/deps.nix
@@ -63,7 +63,6 @@
   (fetchNuGet { pname = "Microsoft.Extensions.Options.ConfigurationExtensions"; version = "8.0.0"; hash = "sha256-A5Bbzw1kiNkgirk5x8kyxwg9lLTcSngojeD+ocpG1RI="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.extensions.options.configurationextensions/8.0.0/microsoft.extensions.options.configurationextensions.8.0.0.nupkg"; })
   (fetchNuGet { pname = "Microsoft.Extensions.Primitives"; version = "8.0.0"; hash = "sha256-FU8qj3DR8bDdc1c+WeGZx/PCZeqqndweZM9epcpXjSo="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.extensions.primitives/8.0.0/microsoft.extensions.primitives.8.0.0.nupkg"; })
   (fetchNuGet { pname = "Microsoft.IO.Redist"; version = "6.0.0"; hash = "sha256-pa3MT+QWrWeehQwUWtTS/Rwto8IIDgAt+zLqaUAQoJ0="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.io.redist/6.0.0/microsoft.io.redist.6.0.0.nupkg"; })
-  (fetchNuGet { pname = "Microsoft.Net.Compilers.Toolset"; version = "4.11.0-2.24270.4"; hash = "sha256-R4+eMGnUz3Jt4kc0WZdaixaqxO2osKa9RJeMMAMaFAw="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/d1622942-d16f-48e5-bc83-96f4539e7601/nuget/v3/flat2/microsoft.net.compilers.toolset/4.11.0-2.24270.4/microsoft.net.compilers.toolset.4.11.0-2.24270.4.nupkg"; })
   (fetchNuGet { pname = "Microsoft.NET.StringTools"; version = "17.10.4"; hash = "sha256-nXY7YaIx6sXn7aMqpF4bW4d2J5U1KNb9sXqRSd8MpOc="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.net.stringtools/17.10.4/microsoft.net.stringtools.17.10.4.nupkg"; })
   (fetchNuGet { pname = "Microsoft.NET.StringTools"; version = "17.3.4"; hash = "sha256-xLPrrL8iS3gNMIa/C/Wv0fBfHIehUHeQ4Y+F+gbqkhk="; url = "https://pkgs.dev.azure.com/azure-public/3ccf6661-f8ce-4e8a-bb2e-eff943ddd3c7/_packaging/491596af-6d2d-439e-80bb-1ebb3b54f9a8/nuget/v3/flat2/microsoft.net.stringtools/17.3.4/microsoft.net.stringtools.17.3.4.nupkg"; })
   (fetchNuGet { pname = "Microsoft.NET.StringTools"; version = "17.4.0"; hash = "sha256-+9uBaUDZ3roUJwyYJUL30Mz+3C6LE16FzfQKgS0Yveo="; url = "https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/45bacae2-5efb-47c8-91e5-8ec20c22b4f8/nuget/v3/flat2/microsoft.net.stringtools/17.4.0/microsoft.net.stringtools.17.4.0.nupkg"; })
diff --git a/pkgs/by-name/ro/roslyn-ls/package.nix b/pkgs/by-name/ro/roslyn-ls/package.nix
index 56a86295efdb..42274eb9206f 100644
--- a/pkgs/by-name/ro/roslyn-ls/package.nix
+++ b/pkgs/by-name/ro/roslyn-ls/package.nix
@@ -43,6 +43,7 @@ buildDotnetModule rec {
   dotnetFlags = [
     # this removes the Microsoft.WindowsDesktop.App.Ref dependency
     "-p:EnableWindowsTargeting=false"
+    "-p:UsingToolMicrosoftNetCompilers=false"
   ];
 
   # two problems solved here:

However, I haven't tested the resulting binary (other than roslyn-ls.tests).

I was able to track down the stack overflow to a specific csc invocation, and wasn't able to reproduce it using the compiler from the 9.0 preview 6 sdk. I believe the change above will cause it to use the SDK compiler.

corngood · 2024-07-29T15:32:03Z

Result of nixpkgs-review pr 318497 run on x86_64-linux 1

1 package built:

roslyn-ls

corngood · 2024-07-29T15:40:07Z

I also built this on darwin, but I had to disable the sandbox due to NixOS/nix#4119.

konradmalik · 2024-07-29T15:46:14Z

Thank you @corngood for the help and fix! I'm building and testing on darwin right now.
I also think we can remove sdk_6_0 from here. I'll follow up.

konradmalik · 2024-07-29T16:46:08Z

ok, I removed all sdks except for 9_0 - it does not influence deps.nix anymore and the app still builds and works fine.

konradmalik · 2024-07-29T16:58:46Z

Result of nixpkgs-review pr 318497 run on x86_64-linux 1

1 package built:

roslyn-ls

corngood · 2024-07-29T17:02:49Z

Thanks! Looks good to me. Are you happy if I merge it now?

corngood · 2024-07-29T17:05:30Z

Have you tested with a project that isn't using SDK 9? I assume so, but I just want to double check that the SDK change doesn't reduce compatibility.

konradmalik · 2024-07-29T17:12:15Z

Result of nixpkgs-review pr 318497 run on x86_64-darwin 1

1 package built:

roslyn-ls

konradmalik · 2024-07-29T17:20:10Z

@corngood now I am ok to merge, as darwin has just built 😄
I've tested it with a project that uses dotnet 8 and works fine.

konradmalik changed the title ~~roslyn-ls: 4.10.0-2.24124.2 -> 4.11.0-2.24267.3~~ roslyn-ls: 4.10.0-2.24124.2 -> 4.11.0-2.24259.4 Jun 9, 2024

konradmalik changed the title ~~roslyn-ls: 4.10.0-2.24124.2 -> 4.11.0-2.24259.4~~ roslyn-ls: 4.10.0-2.24124.2 -> 4.11.0-2.24267.3 Jun 9, 2024

ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 9, 2024

SuperSandro2000 approved these changes Jun 9, 2024

View reviewed changes

konradmalik added the 2.status: work-in-progress This PR isn't done label Jun 9, 2024

konradmalik force-pushed the roslyn-ls branch from 4f48924 to 4b7e728 Compare June 10, 2024 18:02

konradmalik marked this pull request as ready for review June 11, 2024 12:04

konradmalik removed the 2.status: work-in-progress This PR isn't done label Jun 11, 2024

konradmalik force-pushed the roslyn-ls branch from 4b7e728 to 86c7e1d Compare June 11, 2024 12:36

konradmalik marked this pull request as draft June 11, 2024 15:35

konradmalik force-pushed the roslyn-ls branch from 86c7e1d to 128b597 Compare June 13, 2024 08:41

konradmalik changed the title ~~roslyn-ls: 4.10.0-2.24124.2 -> 4.11.0-2.24267.3~~ roslyn-ls: 4.10.0-2.24124.2 -> 4.11.0-3.24307.2 Jun 13, 2024

konradmalik added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jun 13, 2024

konradmalik force-pushed the roslyn-ls branch from 128b597 to 58da625 Compare July 25, 2024 12:33

konradmalik changed the title ~~roslyn-ls: 4.10.0-2.24124.2 -> 4.11.0-3.24307.2~~ roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11 Jul 25, 2024

konradmalik mentioned this pull request Jul 28, 2024

roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24378.2 #330683

Closed

13 tasks

konradmalik force-pushed the roslyn-ls branch from 58da625 to b4765e3 Compare July 29, 2024 15:20

konradmalik requested a review from corngood July 29, 2024 15:46

konradmalik removed the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Jul 29, 2024

corngood approved these changes Jul 29, 2024

View reviewed changes

konradmalik marked this pull request as ready for review July 29, 2024 16:03

roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11

e597d01

ofborg bot removed the 10.rebuild-linux: 1 label Jul 29, 2024

konradmalik force-pushed the roslyn-ls branch from b4765e3 to e597d01 Compare July 29, 2024 16:45

corngood merged commit a8e896a into NixOS:master Jul 29, 2024
17 of 18 checks passed

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jul 29, 2024

konradmalik mentioned this pull request Jul 30, 2024

.NET 6/7 are EOL #326335

Open

17 tasks

konradmalik added the 6.topic: dotnet Language: .NET label Jul 30, 2024

sharpchen mentioned this pull request Aug 19, 2024

Package request: Microsoft.CodeAnalysis.LanguageServer #334511

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11 #318497

roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11 #318497

konradmalik commented Jun 9, 2024 •

edited

Loading

konradmalik commented Jun 9, 2024

konradmalik commented Jun 11, 2024 •

edited

Loading

konradmalik commented Jul 28, 2024 •

edited

Loading

SuperSandro2000 commented Jul 28, 2024

corngood commented Jul 29, 2024

corngood commented Jul 29, 2024

corngood commented Jul 29, 2024

konradmalik commented Jul 29, 2024

konradmalik commented Jul 29, 2024

konradmalik commented Jul 29, 2024

corngood commented Jul 29, 2024

corngood commented Jul 29, 2024

konradmalik commented Jul 29, 2024

konradmalik commented Jul 29, 2024 •

edited

Loading

roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11 #318497

roslyn-ls: 4.10.0-2.24124.2 -> 4.12.0-1.24359.11 #318497

Conversation

konradmalik commented Jun 9, 2024 • edited Loading

Description of changes

Things done

konradmalik commented Jun 9, 2024

konradmalik commented Jun 11, 2024 • edited Loading

konradmalik commented Jul 28, 2024 • edited Loading

SuperSandro2000 commented Jul 28, 2024

corngood commented Jul 29, 2024

corngood commented Jul 29, 2024

corngood commented Jul 29, 2024

konradmalik commented Jul 29, 2024

konradmalik commented Jul 29, 2024

konradmalik commented Jul 29, 2024

corngood commented Jul 29, 2024

corngood commented Jul 29, 2024

konradmalik commented Jul 29, 2024

konradmalik commented Jul 29, 2024 • edited Loading

konradmalik commented Jun 9, 2024 •

edited

Loading

konradmalik commented Jun 11, 2024 •

edited

Loading

konradmalik commented Jul 28, 2024 •

edited

Loading

konradmalik commented Jul 29, 2024 •

edited

Loading