[24.05] haskell.packages.*.ghc-{lib,tags}: pick correct version(s)#318387
Merged
sternenseemann merged 3 commits intoNixOS:release-24.05from Jun 12, 2024
Merged
[24.05] haskell.packages.*.ghc-{lib,tags}: pick correct version(s)#318387sternenseemann merged 3 commits intoNixOS:release-24.05from
sternenseemann merged 3 commits intoNixOS:release-24.05from
Conversation
I suspect that we'll be able to upgrade to 9.10.* for all three packages after the next haskell-language-server update. I'll leave that to maralorn. (cherry picked from commit b30eb6f)
This matches what we do for GHC 8.10.7 where we also can't build the 9.6 versions. (cherry picked from commit 8ff463e)
This just requires picking the right version of the package for all compiler versions. (cherry picked from commit bd69426)
github-actions
bot
added
the
6.topic: haskell
Member
Author
|
Builds of all changed ghc-libs and all ghc-tags versions succeed. |
ofborg
bot
added
8.has: package (new)
maralorn
approved these changes
Jun 12, 2024
Member
maralorn
left a comment
maralorn
left a comment
There was a problem hiding this comment.
LGTM,
I wondered if this might affect an hls, but it apparently doesn’t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Backported from #315167.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.