Skip to content

flite: refactor & modernize#318370

Merged
vcunat merged 6 commits intoNixOS:stagingfrom
getchoo-contrib:pkgs/flite/refactor
Jun 24, 2024
Merged

flite: refactor & modernize#318370
vcunat merged 6 commits intoNixOS:stagingfrom
getchoo-contrib:pkgs/flite/refactor

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Jun 8, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 8, 2024
@isabelroses isabelroses added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 9, 2024
afh
afh approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice refactor and modernization, @getchoo, well done!
See comment below if you wanted to go above and beyond 🙂

@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Jun 10, 2024
@getchoo getchoo removed the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jun 12, 2024
@getchoo getchoo requested review from afh and jtbx June 12, 2024 05:32
@getchoo getchoo force-pushed the pkgs/flite/refactor branch from 2f80657 to d09e585 Compare June 12, 2024 05:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 12, 2024
@getchoo getchoo marked this pull request as draft June 12, 2024 07:31
@getchoo getchoo force-pushed the pkgs/flite/refactor branch from d09e585 to 995a987 Compare June 12, 2024 07:31
@getchoo getchoo changed the base branch from master to staging June 12, 2024 07:31
@getchoo getchoo marked this pull request as ready for review June 12, 2024 07:31
@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. labels Jun 12, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Jun 12, 2024
afh
afh approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@afh afh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done, @getchoo, thanks!

pkgs/by-name/fl/flite/package.nix

meta = {
description = "Small, fast run-time speech synthesis engine";
homepage = "http://www.festvox.org/flite/";
Copy link
Member

@afh afh Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad the site does not offer https :/

@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jun 14, 2024
@vcunat
Copy link
Member

vcunat commented Jun 24, 2024

@ofborg eval
(it's showing nonsense, probably due to race with rebase)

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 24, 2024
@vcunat vcunat merged commit cf3f00f into NixOS:staging Jun 24, 2024
@getchoo getchoo deleted the pkgs/flite/refactor branch June 24, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afh afh afh approved these changes

@jtbx jtbx Awaiting requested review from jtbx

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@getchoo @vcunat @afh @jtbx @wegank @isabelroses