tpm2-tss: remove shadow dependency

[tie]

Description of changes

Fixes tpm2-tss (cross-)build on macOS since shadow package is Linux-specific and therefore cannot be used in nativeBuildInputs.

Split from #317651

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin → x86_64-linux
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[tie]

@baloo, gentle ping. You’ve approved these changes on the original PR (#317651 (review)), are you still OK with them?

[baloo]

Ha, I missed that notification sorry. Thanks for the ping.

[baloo]

Would you mind changing the meta.platforms as well?

[tie]

Would you mind changing the meta.platforms as well?

This PR is for building tmp2-tss for Linux on macOS, e.g.

(import <nixpkgs> {
  localSystem = "aarch64-darwin";
  crossSystem = "x86_64-linux";
}).tpm2-tss

I’m not really sure if it builds for macOS as-is after this change, I’ll try building tpm2-tss once my macOS builder finishes building another PR.

[baloo]

Ha good point. Sorry I got a bit too excited haha.
I had the need to compile tpm2-tss on macos (not to interact with a TPM directly but because it's required for makecredentials) for coworkers to be able to help, but I don't have access to a macos myself.

[tie]

Yes, I don’t think tpm2-tss supports macOS. It’s trivial to convince build system to actually build for macOS, but the code uses uchar.h header (that is not available on macOS) in a few places and I gave up at that point.

There seems to be an upstream issue for macOS support, tpm2-software/tpm2-tss#2629

[tie]

@JohnRTitor, hi, can you take a look at this please (and hopefully merge if everything is OK)?

[JohnRTitor]

Thanks for the review request, however as I am not knowledgeable in this topic, I am not confident that replacing this with a dummy package won't cause any issues.

If in future the package ends up relying more on this dependency, this change would break the package then.

I'll let others handle this.

[tie]

I’ve removed the need for dummy package by converting relevant AC_MSG_ERROR to AC_MSG_WARN in configure.ac (see #317786 (comment)). As pointed out in #317786 (comment), this is already a warning instead of an error at install phase, so it shouldn’t be an error at configure phase.

[vcunat]

At a glance the patch looks like something worth trying to upstream.

[numinit]

Totally agreed, it somewhat seems like a bug.