Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displaylink: 5.8.0-63.33 -> 6.0.0-24 #317292

Closed
wants to merge 2 commits into from

Conversation

GeoffreyFrogeye
Copy link
Contributor

@GeoffreyFrogeye GeoffreyFrogeye commented Jun 4, 2024

Description of changes

Changelog from the archive:

C.9 Changes in 6.0 release

  • DL-7xxx: Support for DP++ (HDMI) video
  • DL-7xxx: Added Unigraf UCD-400/500 for DisplayPort compliance testing
  • DL-6xxx series: incorrect image at 2560x1440@60 on some DisplayPort monitors
  • Added preliminary support for kernel 6.9
  • General stability updates and bug fixes

C.8 Changes in 5.9 release

  • Drop support for Ubuntu 18.04

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Confirmed working with a 17e9:4318 DisplayLink Dell USB 3.0 Dock.

This is a major release in the semver sense of the term, but I'm not sure whether it is worth adding an entry in the release notes.

I am not super familiar with the package, so I haven't looked deeply whether more needs updating, but I figured this would be a starting point.


Add a 👍 reaction to pull requests you find important.

@GeoffreyFrogeye
Copy link
Contributor Author

If I'm not mistaken ofborg should have requested a review from the package maintainers, maybe it didn't do so because I force-pushed while it was still running? So, uh, ping @abbradar

Copy link
Contributor

@toastal toastal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds & runs for me, but we should be wary that evdi current isn’t compatible with linux_testing @ v6.10.0-rc* DisplayLink/evdi#469

Copy link
Member

@montchr montchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also builds and runs for me on aarch64-linux. Thank you!

FWIW: after updating NixOS sometime in the past couple weeks, I encountered a severe (unusable) lag on my external monitor, which I can only use via a DisplayLink hub. I am running GNOME Desktop via nixos-unstable on a MacBook Air M2 (https://github.com/tpwrules/nixos-apple-silicon/). Unfortunately for me, updating to DisplayLink 6.0.0-24 did not resolve the issue, so it's probably related to my configuration.

@montchr
Copy link
Member

montchr commented Jun 30, 2024

This builds & runs for me, but we should be wary that evdi current isn’t compatible with linux_testing @ v6.10.0-rc* DisplayLink/evdi#469

Looks like they released a fix in v1.14.5, though they did not actually close the issue.

DisplayLink/evdi#469 (comment)

@karlskewes
Copy link
Contributor

FWIW a separate PR #324121 updating to 6.0 has been merged.

@drupol drupol closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants