icu: enable updateAutotoolsGnuConfigScriptsHook#317218
Merged
7c6f434c merged 1 commit intoNixOS:stagingfrom Jun 5, 2024
Merged
icu: enable updateAutotoolsGnuConfigScriptsHook#3172187c6f434c merged 1 commit intoNixOS:stagingfrom
7c6f434c merged 1 commit intoNixOS:stagingfrom
Conversation
ofborg
bot
added
the
10.rebuild-darwin-stdenv
ofborg
bot
added
10.rebuild-darwin: 501+
Contributor
Author
|
Oh dear, this is a mass rebuild. I'm going to try to rebase it as per CONTRIBUTING, let's cross our fingers... |
7c6f434c
approved these changes
Jun 4, 2024
Member
|
Does this mean that it is not enough that the upstream regenerates the configure script? |
Contributor
Author
|
If upstream regenerates the configure script with a gnu-config that postdates https://git.savannah.gnu.org/cgit/config.git/commit/?id=e4786449e1c26716e3f9ea182caf472e4dbc96e0 then it will be fine. Until then we get errors from /usr/bin/uname not found. |
14 tasks
This was referenced Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Continuation of #313496
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.