Skip to content

release-combined: fix eval#317172

Merged
Mic92 merged 1 commit into
NixOS:masterfrom
Mic92:fix-eval
Jun 4, 2024
Merged

release-combined: fix eval#317172
Mic92 merged 1 commit into
NixOS:masterfrom
Mic92:fix-eval

Conversation

@Mic92
Copy link
Copy Markdown
Member

@Mic92 Mic92 commented Jun 4, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Jun 4, 2024
@mweinelt mweinelt added the 1.severity: channel blocker Blocks a channel label Jun 4, 2024
@mweinelt
Copy link
Copy Markdown
Member

mweinelt commented Jun 4, 2024

And release-small.nix.

@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented Jun 4, 2024

It's not part of it. Should it be added?

@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented Jun 4, 2024

Currently running:

nix run ../nix-eval-jobs -- --force-recurse nixos/release-combined.nix

Is there a different command for this?

Comment thread nixos/release-small.nix Outdated
@Mic92 Mic92 force-pushed the fix-eval branch 2 times, most recently from 810bc01 to 7c83846 Compare June 4, 2024 12:06
@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented Jun 4, 2024

I believe this is correct now. Otherwise, it cannot break more than that.

@Mic92 Mic92 merged commit 50a127f into NixOS:master Jun 4, 2024
@Mic92 Mic92 deleted the fix-eval branch June 4, 2024 12:25
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 4, 2024
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Jun 5, 2024

The big release also needed this: PR #317485
Now we got a trunk-combined eval again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: channel blocker Blocks a channel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants