Skip to content

stdenv: promote zerocallusedregs to defaultHardeningFlags #316761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
risicle merged 2 commits into from
Jun 3, 2024
Merged

stdenv: promote zerocallusedregs to defaultHardeningFlags #316761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c85826c
llvmPackages_17.llvm: add patch to fix -fzero-call-used-regs crashes
risicle Jun 2, 2024
dd80ca4
stdenv: promote zerocallusedregs to defaultHardeningFlags
risicle Jun 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/build-support/bintools-wrapper/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"relro"
"stackprotector"
"strictoverflow"
"zerocallusedregs"
] ++ lib.optional (with stdenvNoCC;
# Musl-based platforms will keep "pie", other platforms will not.
# If you change this, make sure to update section `{#sec-hardening-in-nixpkgs}`
Expand Down
8 changes: 8 additions & 0 deletions pkgs/development/compilers/llvm/17/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,14 @@ in let
# It's not clear to me why this isn't an issue for LLVM developers running
# on macOS (nothing about this _seems_ nix specific)..
./llvm/lit-shell-script-runner-set-dyld-library-path.patch

# resolves https://github.com/llvm/llvm-project/issues/75168
(fetchpatch {
name = "fix-fzero-call-used-regs.patch";
url = "https://github.com/llvm/llvm-project/commit/f800c1f3b207e7bcdc8b4c7192928d9a078242a0.patch";
stripLen = 1;
hash = "sha256-e8YKrMy2rGcSJGC6er2V66cOnAnI+u1/yImkvsRsmg8=";
})
];
pollyPatches = [
./llvm/gnu-install-dirs-polly.patch
Expand Down
1 change: 0 additions & 1 deletion pkgs/top-level/stage.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ let
pkgsExtraHardening = super';
stdenv = super'.withDefaultHardeningFlags (
super'.stdenv.cc.defaultHardeningFlags ++ [
"zerocallusedregs"
"trivialautovarinit"
]
) super'.stdenv;
Expand Down