haskellPackages.jsaddle-hello: fix on darwin #316277
haskellPackages.jsaddle-hello: fix on darwin #316277sternenseemann merged 5 commits intoNixOS:haskell-updatesfrom
Conversation
alexfmpe
requested review from
maralorn,
ncfavier and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
ofborg
bot
added
6.topic: darwin
|
sterni apparently wants to comment on this as well. I think this largely makes sense. |
There was a problem hiding this comment.
How did you hit this? Seems like building warp hasn't been a problem so far.
There was a problem hiding this comment.
Might be some combination of sandbox + firewall. I'll try to isolate the trigger
There was a problem hiding this comment.
This builds for me with --option sandbox false, does not build with relaxed or true.
Test suite just hangs after the "range requests" group log and there's no more output:
https://github.com/yesodweb/wai/blob/d50e1184600631a114e3d2ad119abdf0ef08834b/warp/test/ResponseSpec.hs#L106
I suspect this is the first case in the suite that actually performs a network request (apparently in 127.0.0.1 flavor)
There was a problem hiding this comment.
Do you hit this with just GHC 9.8? warp does seem to succeed with GHC 9.6 which is confusing to me.
There was a problem hiding this comment.
On further testing it looks like it only happens when both firewall AND sandboxing are active.
Didn't try 9.8.
3 participants
Strictly speaking,
ghcjs-dom-hellofails with a linker error on my mac but I suspect that's just for aarch64-darwin since I've often hit #149692. Should be fixed when the cctools bump is merged.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.