llvmPackages_18.compiler-rt: adjust FreeBSD assert patch for LLVM 18#316253
Merged
Ericson2314 merged 1 commit intoNixOS:stagingfrom Jun 1, 2024
Merged
llvmPackages_18.compiler-rt: adjust FreeBSD assert patch for LLVM 18#316253Ericson2314 merged 1 commit intoNixOS:stagingfrom
Ericson2314 merged 1 commit intoNixOS:stagingfrom
Conversation
14 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Ericson2314
approved these changes
Jun 1, 2024
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
@rhelmot informs me the x86 assumptions me be more pervasive than this, this is just the first time I noticed them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This file was moved for the LLVM 18 release. Adjust our patch accordingly, similar to the case for the other platforms.
This targets staging because #311777 hasn't made it to master yet.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.