Skip to content

nixVersions.stable: reference nixos-smoketets test #315878

Closed
Mic92 wants to merge 2 commits into
NixOS:masterfrom
Mic92:nix
Closed

nixVersions.stable: reference nixos-smoketets test #315878
Mic92 wants to merge 2 commits into
NixOS:masterfrom
Mic92:nix

Conversation

@Mic92
Copy link
Copy Markdown
Member

@Mic92 Mic92 commented May 30, 2024

According to the previous nix maintainer, this test is critical for nix upgrades.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Mic92 Mic92 requested review from Ma27 and RaitoBezarius as code owners May 30, 2024 12:35
@ofborg ofborg Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 30, 2024
@github-actions github-actions Bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label May 30, 2024
@Mic92 Mic92 changed the title nixVersions.stable: add misc test to nix tests nixVersions.stable: reference nixos-smoketets test May 30, 2024
@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented May 30, 2024

cc @mweinelt I went for nixos-smoketests. I hope this one is better?

@ofborg ofborg Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 30, 2024
@Artturin
Copy link
Copy Markdown
Member

How about #315927 instead?

@Mic92
Copy link
Copy Markdown
Member Author

Mic92 commented May 30, 2024

Yes. This one looks better.

@Mic92 Mic92 closed this May 30, 2024
@Mic92 Mic92 deleted the nix branch May 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants